Fix connection of animated nodes and scroll offset with useNativeDriver. #24177

msand · 2019-03-28T03:10:44Z

Add example showing regression before this fix is applied.

Summary

#18187 Was found to introduce a regression in some internal facebook code-base end to end test which couldn't be shared. I was able to create a reproducible demo of a regression I found, and made a fix for it. Hopefully this will fix the internal test, such that the pr can stay merged.

Changelog

[GENERAL] [Fixed] - Fix connection of animated nodes and scroll offset with useNativeDriver.

Test Plan

The commit includes a new example for RNTester. Unit and E2E integration could be added in a later commit.

ping @cpojer

analysis-bot

Code analysis results:

flow found some issues.

RNTester/js/ScrollViewAnimatedExample.js

… when using native driver in Animated, fix Expected node to be marked as "native", optimize AnimatedNode creation and connections"" This reverts commit 95c7db9

analysis-bot

Code analysis results:

flow found some issues.

RNTester/js/ScrollViewAnimatedExample.js

analysis-bot

Code analysis results:

flow found some issues.

RNTester/js/ScrollViewAnimatedExample.js

analysis-bot

Code analysis results:

flow found some issues.

RNTester/js/ScrollViewAnimatedExample.js

Add example showing regression before this fix is applied.

facebook-github-bot

@cpojer has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

cpojer · 2019-04-09T00:56:32Z

Let me get back to this one!

Libraries/NativeAnimation/Nodes/RCTInterpolationAnimatedNode.m

software-mansion/react-native-svg#951 (comment)

facebook-github-bot

@cpojer has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

facebook-github-bot

@cpojer has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

matpaul · 2019-06-04T19:24:37Z

@cpojer Hello! what stop to merge this pr?)
Tested it with patch in production everything work very good (morphing 'svg' with nativeDriver awesome!)

cpojer · 2019-06-05T12:41:32Z

I finally got a strong enough computer to run the tests locally at FB :D I rebased this internally at FB and can verify that as far as I can see the previous issue should be resolved. I'm trying to land it now.

Change O(n^2) to O(n)

msand · 2019-06-05T15:13:28Z

@cpojer I made a small change to optimize the connection queue handling

matthargett

Thanks for adding an RNTester page that captures this use case!

react-native-bot · 2019-06-06T11:55:05Z

This pull request was successfully merged by @msand in bdc530b.

^{When will my fix make it into a release? | Upcoming Releases}

Summary: Change O(n^2) to O(n) Minor follow-up to: #24177 ## Changelog [Internal] [Changed] - Optimize native animated connection queue handling Pull Request resolved: #25256 Differential Revision: D15804527 Pulled By: cpojer fbshipit-source-id: 4a1e1b51faf6ed7b98eb08aa47e18cfaea541dad

- facebook/react-native#24177

…er. (facebook#24177) Summary: Add example showing regression before this fix is applied. facebook#18187 Was found to introduce a regression in some internal facebook code-base end to end test which couldn't be shared. I was able to create a reproducible demo of a regression I found, and made a fix for it. Hopefully this will fix the internal test, such that the pr can stay merged. ## Changelog [GENERAL] [Fixed] - Fix connection of animated nodes and scroll offset with useNativeDriver. Pull Request resolved: facebook#24177 Reviewed By: rickhanlonii Differential Revision: D14845617 Pulled By: cpojer fbshipit-source-id: 1f121dbe773b0cde2adf1ee5a8c3c0266034e50d

Summary: Change O(n^2) to O(n) Minor follow-up to: facebook#24177 ## Changelog [Internal] [Changed] - Optimize native animated connection queue handling Pull Request resolved: facebook#25256 Differential Revision: D15804527 Pulled By: cpojer fbshipit-source-id: 4a1e1b51faf6ed7b98eb08aa47e18cfaea541dad

facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 28, 2019

analysis-bot suggested changes Mar 28, 2019

View reviewed changes

RNTester/js/ScrollViewAnimatedExample.js Outdated Show resolved Hide resolved

RNTester/js/ScrollViewAnimatedExample.js Outdated Show resolved Hide resolved

react-native-bot added API: Animated Includes Changelog labels Mar 28, 2019

Revert "Back out "[react-native][PR] Support Interpolation of strings…

2fc6888

… when using native driver in Animated, fix Expected node to be marked as "native", optimize AnimatedNode creation and connections"" This reverts commit 95c7db9

msand force-pushed the fix-native-animated-scroll-offset-connection branch from f25b657 to 80e5a9e Compare March 28, 2019 03:21

msand requested a review from janicduplessis as a code owner March 28, 2019 03:22

analysis-bot suggested changes Mar 28, 2019

View reviewed changes

RNTester/js/ScrollViewAnimatedExample.js Outdated Show resolved Hide resolved

RNTester/js/ScrollViewAnimatedExample.js Outdated Show resolved Hide resolved

msand force-pushed the fix-native-animated-scroll-offset-connection branch from 80e5a9e to f7507e2 Compare March 28, 2019 03:23

analysis-bot suggested changes Mar 28, 2019

View reviewed changes

RNTester/js/ScrollViewAnimatedExample.js Outdated Show resolved Hide resolved

msand force-pushed the fix-native-animated-scroll-offset-connection branch from f7507e2 to 827fc61 Compare March 28, 2019 03:27

analysis-bot suggested changes Mar 28, 2019

View reviewed changes

RNTester/js/ScrollViewAnimatedExample.js Outdated Show resolved Hide resolved

RNTester/js/ScrollViewAnimatedExample.js Outdated Show resolved Hide resolved

msand force-pushed the fix-native-animated-scroll-offset-connection branch from 827fc61 to f2643d1 Compare March 28, 2019 03:29

Fix connection of animated nodes and scroll offset with useNativeDriver.

ab49cb0

Add example showing regression before this fix is applied.

msand force-pushed the fix-native-animated-scroll-offset-connection branch from f2643d1 to ab49cb0 Compare March 28, 2019 03:37

facebook-github-bot reviewed Apr 9, 2019

View reviewed changes

matpaul reviewed Apr 15, 2019

View reviewed changes

Libraries/NativeAnimation/Nodes/RCTInterpolationAnimatedNode.m Outdated Show resolved Hide resolved

Fix handling of zero and one in native string interpolation

86052af

software-mansion/react-native-svg#951 (comment)

facebook-github-bot reviewed Apr 15, 2019

View reviewed changes

msand added 2 commits April 15, 2019 23:43

[android] Improve integer handling in rgba string interpolation

dc3f54a

[android] Improve integer handling in rgba string interpolation

50d7074

msand mentioned this pull request Apr 16, 2019

Animated Path d attribute software-mansion/react-native-svg#951

Closed

[animated] Support scientific notation in string interpolation

19bba43

msand force-pushed the fix-native-animated-scroll-offset-connection branch from ace654a to 19bba43 Compare April 16, 2019 01:43

facebook-github-bot reviewed Apr 16, 2019

View reviewed changes

react-native-bot added the Bug label May 3, 2019

hramos removed the Includes Changelog label May 6, 2019

Optimize native animated connection queue handling

2f36236

Change O(n^2) to O(n)

matthargett approved these changes Jun 5, 2019

View reviewed changes

facebook-github-bot closed this in bdc530b Jun 6, 2019

react-native-bot added the Merged This PR has been merged. label Jun 6, 2019

msand mentioned this pull request Jun 13, 2019

Optimize native animated connection queue handling #25256

Closed

EvanBacon added a commit to EvanBacon/react-native-web that referenced this pull request Sep 17, 2019

Fix connection of animated nodes and scroll offset with useNativeDriver.

46bd0b1

- facebook/react-native#24177

msand mentioned this pull request Nov 18, 2019

Animating SVG's using useNativeDriver: true software-mansion/react-native-svg#1195

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix connection of animated nodes and scroll offset with useNativeDriver. #24177

Fix connection of animated nodes and scroll offset with useNativeDriver. #24177

msand commented Mar 28, 2019

analysis-bot left a comment

analysis-bot left a comment

analysis-bot left a comment

analysis-bot left a comment

facebook-github-bot left a comment

cpojer commented Apr 9, 2019

facebook-github-bot left a comment

facebook-github-bot left a comment

matpaul commented Jun 4, 2019

cpojer commented Jun 5, 2019

msand commented Jun 5, 2019

matthargett left a comment

react-native-bot commented Jun 6, 2019

Fix connection of animated nodes and scroll offset with useNativeDriver. #24177

Fix connection of animated nodes and scroll offset with useNativeDriver. #24177

Conversation

msand commented Mar 28, 2019

Summary

Changelog

Test Plan

analysis-bot left a comment

Choose a reason for hiding this comment

analysis-bot left a comment

Choose a reason for hiding this comment

analysis-bot left a comment

Choose a reason for hiding this comment

analysis-bot left a comment

Choose a reason for hiding this comment

facebook-github-bot left a comment

Choose a reason for hiding this comment

cpojer commented Apr 9, 2019

facebook-github-bot left a comment

Choose a reason for hiding this comment

facebook-github-bot left a comment

Choose a reason for hiding this comment

matpaul commented Jun 4, 2019

cpojer commented Jun 5, 2019

msand commented Jun 5, 2019

matthargett left a comment

Choose a reason for hiding this comment

react-native-bot commented Jun 6, 2019