[Lexical] Add label to run e2e tests on approve #6120
Conversation
Sahejkm
requested review from
zurfyx,
fantactuka,
acywatson,
Fetz and
ivailop7
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
facebook-github-bot
added
the
CLA Signed
size-limit report 📦
|
Sahejkm
changed the title
| e2e-tests: | ||
| needs: label_pull_requests | ||
| uses: ./.github/workflows/call-e2e-all-tests.yml |
There was a problem hiding this comment.
I don't think this is right. Once the label is added, it should kick off the other tests-extended workflow automatically, as that already gets triggered when labels are added.
There was a problem hiding this comment.
I tested this and found out that 1 GitHub workflow action can't trigger another workflow action and hence this was needed, with a "needs" check , the second job won't run unless 1 job is not skipped. Without this tests don't trigger on approve unless there is a manual action, other way to fix this is use PAT tokens to trigger the 1st job to add labels,but I think we should still use the GitHub action bot.
|
|
||
| concurrency: | ||
| group: ${{ github.workflow }}-${{ github.ref }} | ||
| cancel-in-progress: true |
| cancel-in-progress: true | ||
|
|
||
| jobs: | ||
| label_pull_requests: |
There was a problem hiding this comment.
The naming format used for all other workflows is foo-bar. So this one should probably be called something like label-after-approved
There was a problem hiding this comment.
Thanks for the feedback, will update the naming conventions
| @@ -0,0 +1,24 @@ | |||
| name: Add Label to run extended tests on approve | |||
There was a problem hiding this comment.
The file name of this workflow should be 'add-label-after-approved'. This workflow shouldn't be running e2e tests, just adding a label
|
I think the workflow file merged in this PR needs revisiting |
|
It's too bad that GitHub doesn't really offer any way to simulate these things, even to see what a matrix would expand to |
Add label and run extended test on approve
followup on Only run CI e2e tests on approved PRs #6080
Fixes Feature: Add extended-tests label on approval #6097