[Lexical] Add label to run e2e tests on approve #6120
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,24 @@ | ||
| name: Add Label to run extended tests on approve | ||
|
|
||
| on: | ||
| pull_request_review: | ||
|
|
||
| concurrency: | ||
| group: ${{ github.workflow }}-${{ github.ref }} | ||
| cancel-in-progress: true | ||
|
|
||
|
|
||
| jobs: | ||
| label_pull_requests: | ||
|
There was a problem hiding this comment. The naming format used for all other workflows is There was a problem hiding this comment. Thanks for the feedback, will update the naming conventions |
||
| if: github.event.review.state == 'approved' && !contains( github.event.pull_request.labels.*.name, 'extended-tests') | ||
| runs-on: ubuntu-latest | ||
| permissions: | ||
| pull-requests: write | ||
| steps: | ||
| - run: gh pr edit "$NUMBER" --add-label "extended-tests" | ||
| env: | ||
| GH_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
| GH_REPO: ${{ github.repository }} | ||
| NUMBER: ${{ github.event.pull_request.number }} | ||
| e2e-tests: | ||
| needs: label_pull_requests | ||
| uses: ./.github/workflows/call-e2e-all-tests.yml | ||
|
Comment on lines
+22
to
+24
There was a problem hiding this comment. I don't think this is right. Once the label is added, it should kick off the other There was a problem hiding this comment. I tested this and found out that 1 GitHub workflow action can't trigger another workflow action and hence this was needed, with a "needs" check , the second job won't run unless 1 job is not skipped. Without this tests don't trigger on approve unless there is a manual action, other way to fix this is use PAT tokens to trigger the 1st job to add labels,but I think we should still use the GitHub action bot. |
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The file name of this workflow should be 'add-label-after-approved'. This workflow shouldn't be running e2e tests, just adding a label