-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Add extended-tests label on approval #6097
Comments
I think it may better to utilize GH merge queues, in addition to manual triggers/labels: It’s also discussed here: https://github.com/orgs/community/discussions/53922 |
Given that I don't have the authorization to use labels or approvals, I don't have a strong opinion either way. I just thought I should add the follow-up issue based on what was discussed on the workflow PR so it doesn't get forgotten, since at the moment there is an extra step in reviews. As long as it's easy and efficient for the people who are doing the reviews (and not error-prone), I will be happy with it. We should probably also add a few words to the maintainers guide with how the review process works, to communicate the process change to existing maintainers and to make onboarding a new maintainer more efficient. |
Thanks for filing this anyway! We shall solve it either way |
A merge queue is what I first suggested internally too. But didn't realize GitHub now has a built-in version of it! |
following up with OSS team to enable Merge Queue options in for internal meta settings as well, its not visible right now. |
It seems that this didn't work in #6129 when @ivailop7 approved it: https://github.com/facebook/lexical/actions/runs/9133904177/job/25118355291?pr=6129 |
I think it's the same issue as the size limit job to add comments , it doesn't run from forks, and need to use the pull request target event |
When a PR is approved, if the label no-extended-tests is not present, add the extended-tests label.
Could be done with an workflow that uses the gh CLI directly or call an action such as labeler and use a condition to run it only when the PR is approved (and maybe if it touches any of public packages source file, the playground, or a package/package-lock file)
Follow-up to #6080
The text was updated successfully, but these errors were encountered: