Update cpp_binary() to support argument os_deps#9
Closed
ben-- wants to merge 1 commit intofacebook:mainfrom
Closed
Update cpp_binary() to support argument os_deps#9ben-- wants to merge 1 commit intofacebook:mainfrom
ben-- wants to merge 1 commit intofacebook:mainfrom
Conversation
Contributor
Author
|
Tweaked the code on the first comment (about name/srcs). Happy to fully remove the explicit name if you require. For the second, I was just following the example of similar code several places in this same file. Happy to make updates, but I'd love some advice on the proper fix. |
bigfootjon
requested changes
Jun 24, 2025
bigfootjon
approved these changes
Jun 24, 2025
Contributor
|
@bigfootjon has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
facebook-github-bot
pushed a commit
that referenced
this pull request
Jun 25, 2025
Summary: Pull Request resolved: #9 Reviewed By: sdwilsh Differential Revision: D77235819 Pulled By: bigfootjon fbshipit-source-id: 19f183ef9859a2578f0d4dbd22d1817beff61336
facebook-github-bot
pushed a commit
to facebook/ocamlrep
that referenced
this pull request
Jun 25, 2025
Summary: Pull Request resolved: facebook/buck2-shims-meta#9 Reviewed By: sdwilsh Differential Revision: D77235819 Pulled By: bigfootjon fbshipit-source-id: 19f183ef9859a2578f0d4dbd22d1817beff61336
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.