Skip to content

Update cpp_binary() to support argument os_deps #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ben-- wants to merge 1 commit into from
Closed

Update cpp_binary() to support argument os_deps #9

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions shims.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -228,6 +228,7 @@ def cpp_unittest(
def cpp_binary(
deps = [],
external_deps = [],
os_deps = [],
visibility = ["PUBLIC"],
dlopen_enabled = None,
compiler_specific_flags = None,
Expand All @@ -236,6 +237,8 @@ def cpp_binary(
modules = None,
**kwargs):
_unused = (dlopen_enabled, compiler_specific_flags, os_linker_flags, allocator, modules) # @unused
if os_deps:
deps += _select_os_deps(_fix_dict_deps(os_deps))
prelude.cxx_binary(
deps = _fix_deps(deps + external_deps_to_targets(external_deps)),
Comment thread
ben-- marked this conversation as resolved.
visibility = visibility,
Expand Down