Skip to content

compile/link/execute ocaml tests via cargo#9

Closed
shayne-fletcher wants to merge 1 commit intofacebook:mainfrom
shayne-fletcher:integrate-ocaml-tests
Closed

compile/link/execute ocaml tests via cargo#9
shayne-fletcher wants to merge 1 commit intofacebook:mainfrom
shayne-fletcher:integrate-ocaml-tests

Conversation

@shayne-fletcher
Copy link
Copy Markdown
Contributor

@shayne-fletcher shayne-fletcher commented Jan 29, 2023

  • compile, link & execute the ocaml tests via cargo test
  • remove the need to configure OCAMLLIB before cargo build.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 29, 2023
shayne-fletcher
shayne-fletcher commented Jan 29, 2023
View reviewed changes
@shayne-fletcher
Copy link
Copy Markdown
Contributor Author

shayne-fletcher commented Jan 29, 2023 •
edited
Loading

run the two ocaml individually

cargo test -p ocamlpool_test -- --nocapture

[ocamlpool_test info]: start
[ocamlpool_test info]: end
test tests::ocamlpool_test ... ok

cargo test -p test_bindings -- --nocapture

[ocamlrep_test info]: start
[ocamlrep_test info]: end
test tests::ocamlrep_test ... ok

@shayne-fletcher shayne-fletcher force-pushed the integrate-ocaml-tests branch 4 times, most recently from ab2b861 to a2b43ae Compare January 29, 2023 07:36
@shayne-fletcher shayne-fletcher marked this pull request as draft January 29, 2023 15:06
@shayne-fletcher shayne-fletcher force-pushed the integrate-ocaml-tests branch 3 times, most recently from 28f1560 to 9360d83 Compare January 30, 2023 17:45
@shayne-fletcher shayne-fletcher marked this pull request as ready for review January 30, 2023 19:01
@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Jan 30, 2023

@shayne-fletcher has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Jan 30, 2023

@shayne-fletcher merged this pull request in 761c4af.

@shayne-fletcher shayne-fletcher deleted the integrate-ocaml-tests branch January 30, 2023 23:18
facebook-github-bot pushed a commit that referenced this pull request Jun 25, 2025
@ben-- @facebook-github-bot
Update cpp_binary() to support argument os_deps (#9)
a3e819c 
Summary: Pull Request resolved: facebook/buck2-shims-meta#9

Reviewed By: sdwilsh

Differential Revision: D77235819

Pulled By: bigfootjon

fbshipit-source-id: 19f183ef9859a2578f0d4dbd22d1817beff61336
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@shayne-fletcher @facebook-github-bot