✨ Feat: Add maxPriorityFeePerGas and maxFeePerGas #1198
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Warning Rate limit exceeded@roninjin10 has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 50 minutes and 23 seconds before requesting another review. How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. WalkthroughThe code update introduces support for Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant TEVM_Module
participant Transaction_Handler
participant Validator
User->>+TEVM_Module: Initiates transaction with maxFeePerGas and maxPriorityFeePerGas
TEVM_Module->>+Transaction_Handler: Passes fee parameters to createTransaction
Transaction_Handler->>+Validator: Validates maxFeePerGas and maxPriorityFeePerGas
Validator-->>-Transaction_Handler: Validation Result
Transaction_Handler-->>-TEVM_Module: Transaction Created/Rejected
TEVM_Module-->>-User: Transaction Response
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @roninjin10 and the rest of your teammates on |
roninjin10
force-pushed
the
06-13-_sparkles_feat_add_maxpriorityfeepergas_and_maxfeepergas
branch
from
04ac982
to
72a2cff
Compare
🦋 Changeset detectedLatest commit: 366a900 The changes in this PR will be included in the next version bump. This PR includes changesets to release 18 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
roninjin10
force-pushed
the
06-13-_sparkles_feat_add_maxpriorityfeepergas_and_maxfeepergas
branch
from
72a2cff
to
5a81864
Compare
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 3
Outside diff range and nitpick comments (3)
packages/actions/src/internal/evmInputToImpersonatedTx.js (1)
10-11: Ensure proper documentation for the new parametersmaxFeePerGasandmaxPriorityFeePerGas.Consider adding more detailed descriptions for these parameters to help developers understand their usage better.
packages/actions/src/BaseCall/BaseCallParams.ts (1)
71-72: Explain the future fix for thegasPriceoption in more detail.While the note about
gasPricebeing ignored in the context of EIP-1559 transactions is clear, it would be beneficial to provide more specifics on the planned future fix.packages/actions/src/Call/callHandler.js (1)
Line range hint
313-329: Re-run the transaction with adjusted parameters upon specific errors.Consider simplifying this error handling block to enhance maintainability. Multiple nested conditions and error-specific logic can be refactored into a more modular approach.
- if (e.message.includes('block has a different hardfork than the vm') || - e.message.includes("the tx doesn't have the correct nonce.") || - e.message.includes("sender doesn't have enough funds to send tx.") || - e.message.includes("sender doesn't have enough funds to send tx. The upfront cost is")) { + const specificErrors = [ + 'block has a different hardfork than the vm', + "the tx doesn't have the correct nonce.", + "sender doesn't have enough funds to send tx.", + "sender doesn't have enough funds to send tx. The upfront cost is" + ]; + if (specificErrors.some(error => e.message.includes(error))) {This change groups similar error checks into a single condition, making the code cleaner and easier to understand.
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files ignored due to path filters (3)
bundler-packages/resolutions/src/__snapshots__/moduleFactory.spec.ts.snapis excluded by!**/*.snappackages/actions/src/BaseCall/__snapshots__/validateBaseCallParams.spec.ts.snapis excluded by!**/*.snappackages/actions/src/Call/__snapshots__/callHandler.spec.ts.snapis excluded by!**/*.snap
Files selected for processing (18)
- .changeset/big-horses-end.md (1 hunks)
- .changeset/long-islands-behave.md (1 hunks)
- packages/actions/docs/functions/validateBaseCallParams.md (1 hunks)
- packages/actions/docs/type-aliases/BaseCallParams.md (2 hunks)
- packages/actions/src/BaseCall/BaseCallParams.ts (1 hunks)
- packages/actions/src/BaseCall/validateBaseCallParams.js (2 hunks)
- packages/actions/src/BaseCall/validateBaseCallParams.spec.ts (5 hunks)
- packages/actions/src/BaseCall/zBaseCallParams.js (1 hunks)
- packages/actions/src/BaseCall/zBaseCallParams.spec.ts (1 hunks)
- packages/actions/src/Call/callHandler.js (6 hunks)
- packages/actions/src/Call/callHandler.spec.ts (4 hunks)
- packages/actions/src/CreateTransaction/createTransaction.js (2 hunks)
- packages/actions/src/SetAccount/setAccountHandler.js (1 hunks)
- packages/actions/src/internal/evmInputToImpersonatedTx.js (3 hunks)
- packages/errors/src/index.ts (2 hunks)
- packages/errors/src/input/InvalidMaxFeePerGaserror.js (1 hunks)
- packages/errors/src/input/InvalidMaxPriorityFeePerGas.js (1 hunks)
- packages/errors/src/input/index.ts (1 hunks)
Files not reviewed due to errors (1)
- packages/actions/src/Call/callHandler.spec.ts (no review received)
Files skipped from review due to trivial changes (1)
- .changeset/long-islands-behave.md
Additional context used
LanguageTool
packages/actions/docs/functions/validateBaseCallParams.md
[uncategorized] ~13-~13: Possible missing comma found. (AI_HYDRA_LEO_MISSING_COMMA)
Context: ...lidateBaseCallParamsError`[] can break on a minor release Validates that the para...packages/actions/docs/type-aliases/BaseCallParams.md
[uncategorized] ~31-~31: A comma might be missing here. (AI_EN_LECTOR_MISSING_PUNCTUATION_COMMA)
Context: ...the context of that blocks state. To do that fork that block number first. #### Exa...
[style] ~90-~90: Consider shortening this phrase to just ‘whether’, unless you mean ‘regardless of whether’. (WHETHER)
Context: ...|"always"|"never"|booleanWhether or not to update the state or run call in a dr...
[style] ~96-~96: The adverb ‘Always’ is usually put between ‘will’ and ‘still’. (ADVERB_WORD_ORDER)
Context: ...n-success-false: alias fornever` Always will still not include the transaction if it's not...
[uncategorized] ~98-~98: Possible missing comma found. (AI_HYDRA_LEO_MISSING_COMMA)
Context: ...if it's not valid to be included in the chain such as the gas limit being too low. If...
[grammar] ~99-~99: The usual collocation for “returned” is “to”, not “in”. (RETURN_IN_THE)
Context: ... a tx is submitted thetxHashwill be returned in the response. The tx will not be includ...
[uncategorized] ~113-~113: If this is a compound adjective that modifies the following noun, use a hyphen. (EN_COMPOUND_ADJECTIVE_INTERNAL)
Context: ...tionalreadonly**depth**:number` Low level control over the EVM call depth. Useful...
[uncategorized] ~123-~123: A comma may be missing after the conjunctive/linking adverb ‘Otherwise’. (SENT_START_CONJUNCTIVE_LINKING_ADVERB_COMMA)
Context: ...dresses seperately using those options. Otherwise both are set to thefromaddress ###...
[uncategorized] ~143-~143: If this is a compound adjective that modifies the following noun, use a hyphen. (EN_COMPOUND_ADJECTIVE_INTERNAL)
Context: ...alreadonly**gasRefund**:bigintLow level control Refund counter. Defaults to0`...
[style] ~152-~152: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym. (ENGLISH_WORD_REPEAT_BEGINNING_RULE)
Context: ... that can be spent on gas for the call. This is the maximum amount of ether that can...
[typographical] ~166-~166: The word “otherwise” is an adverb that can’t be used like a conjunction, and therefore needs to be separated from the sentence. (THUS_SENTENCE)
Context: ...ess. This defaults tofromaddress if set otherwise it defaults to the zero address ### se...
[uncategorized] ~166-~166: A period might be missing here. (AI_EN_LECTOR_MISSING_PUNCTUATION_PERIOD)
Context: ...f set otherwise it defaults to the zero address ### selfdestruct? >optional`reado...
[style] ~186-~186: ‘prior to’ might be wordy. Consider a shorter alternative. (EN_WORDINESS_PREMIUM_PRIOR_TO)
Context: ...some state to be ephemerally overridden prior to executing the call. Each address maps t...
[grammar] ~191-~191: One modal verb seems to be obsolete here. Consider rephrasing this sentence. (DO_XX_MD_VB)
Context: ...e that simply returns internal state or does pre-defined validations can be kept off chain and fed to the node o...
[uncategorized] ~217-~217: This verb may not be in the correct form. Consider using a different form for this context. (AI_EN_LECTOR_REPLACEMENT_VERB_FORM)
Context: ... to the zero address. To is not set for create transactions but required for most tran...
Markdownlint
packages/actions/docs/type-aliases/BaseCallParams.md
12-12: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines
92-92: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines
Additional comments not posted (19)
.changeset/big-horses-end.md (1)
1-7: The changeset accurately describes the modifications related tomaxFeePerGasandmaxPriorityFeePerGas. The versioning as 'minor' is appropriate given the feature addition.packages/actions/src/BaseCall/zBaseCallParams.spec.ts (1)
14-15: The test cases formaxFeePerGasandmaxPriorityFeePerGasare correctly implemented and ensure the schema handles these new parameters appropriately.packages/actions/docs/functions/validateBaseCallParams.md (1)
26-26: The documentation link is correctly updated to reflect the source code line change. The static analysis hint about a missing comma is a false positive as this is part of a markdown document, not a syntax-sensitive codebase.packages/actions/src/internal/evmInputToImpersonatedTx.js (1)
28-31: Review the logic for setting_maxFeePerGas.Verification successful
The logic for setting
_maxFeePerGasappears to be correctly implemented, as it falls back tobaseFeePerGaswhen_maxFeePerGasis less thanbaseFeePerGas.
- Location:
packages/actions/src/internal/evmInputToImpersonatedTx.jsScripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Ensure that the fallback logic for `_maxFeePerGas` is correctly setting the value based on `baseFeePerGas`. # Test: Search for the usage of `_maxFeePerGas` and `baseFeePerGas`. Expect: Correct fallback logic implementation. rg --type javascript $'_maxFeePerGas = baseFeePerGas'Length of output: 89
Script:
#!/bin/bash # Description: Ensure that the fallback logic for `_maxFeePerGas` is correctly setting the value based on `baseFeePerGas`. # Test: Search for the usage of `_maxFeePerGas` and `baseFeePerGas`. Expect: Correct fallback logic implementation. rg '_maxFeePerGas = baseFeePerGas' --glob '*.js'Length of output: 141
packages/errors/src/input/InvalidMaxFeePerGaserror.js (1)
1-59: Validate the implementation ofInvalidMaxFeePerGasError.The structure and implementation of the error class appear correct and align with the existing patterns for error handling in the codebase.
packages/errors/src/input/InvalidMaxPriorityFeePerGas.js (1)
1-59: Validate the implementation ofInvalidMaxPriorityFeePerGasError.The structure and implementation of this error class are consistent with the project's standards and effectively handle errors related to
maxPriorityFeePerGas.packages/actions/src/BaseCall/zBaseCallParams.js (1)
52-61: Review the addition ofmaxFeePerGasandmaxPriorityFeePerGasto the Zod schema.The schema extensions for
maxFeePerGasandmaxPriorityFeePerGasare well-defined and align with the goals of supporting EIP-1559 transactions.packages/actions/src/BaseCall/validateBaseCallParams.js (2)
16-18: Properly imported new error types for handlingmaxPriorityFeePerGasandmaxFeePerGas.
134-144: Excellent addition of validation logic formaxFeePerGasandmaxPriorityFeePerGas. Ensure the error messages are clear and informative for better user experience.packages/errors/src/index.ts (2)
24-25: Successfully exported new error types related to transaction fees. This will facilitate better error handling in transaction processes.
48-49: Types for the new error parameters are correctly defined and exported, ensuring type safety and clarity in error handling.packages/actions/src/CreateTransaction/createTransaction.js (1)
21-22: Added parametersmaxFeePerGasandmaxPriorityFeePerGasto the function signature. Ensure that all upstream calls to this function are updated to pass these new parameters.Verification successful
The function call to
createTransactionincallHandler.jscorrectly includes the new parametersmaxFeePerGasandmaxPriorityFeePerGas.
packages/actions/src/Call/callHandler.js:
- Line:
const txRes = await createTransaction(client)({Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify all function calls to `createTransaction` match the new signature. # Test: Search for the function usage. Expect: Only occurances of the new signature. rg --type javascript $'createTransaction'Length of output: 75
Script:
#!/bin/bash # Description: Verify all function calls to `createTransaction` match the new signature. # Test: Search for the function usage. Expect: Only occurrences of the new signature. rg --type js $'createTransaction'Length of output: 4272
Script:
#!/bin/bash # Description: Verify all function calls to `createTransaction` match the new signature with parameters `maxFeePerGas` and `maxPriorityFeePerGas`. # Test: Search for function calls and check for correct parameters. rg --type js $'createTransaction('Length of output: 122
Script:
#!/bin/bash # Description: Verify all function calls to `createTransaction` match the new signature with parameters `maxFeePerGas` and `maxPriorityFeePerGas`. # Test: Search for function calls and check for correct parameters. rg --type js 'createTransaction\('Length of output: 128
Script:
#!/bin/bash # Description: Extract lines around the function call to `createTransaction` to verify parameters. # Test: Extract lines around the function call in `callHandler.js`. rg --type js -A 5 -B 5 'createTransaction\(client\)({' packages/actions/src/Call/callHandler.jsLength of output: 230
Script:
#!/bin/bash # Description: Extract lines around the function call to `createTransaction` to verify parameters. # Test: Extract lines around the function call in `callHandler.js`. rg --type js -A 5 -B 5 'createTransaction\(client\)\({' packages/actions/src/Call/callHandler.jsLength of output: 222
Script:
#!/bin/bash # Description: Extract lines around the function call to `createTransaction` to verify parameters. # Test: Extract lines around the function call in `callHandler.js`. rg --type js -A 5 -B 5 'createTransaction\(client\)' packages/actions/src/Call/callHandler.jsLength of output: 455
packages/actions/src/BaseCall/validateBaseCallParams.spec.ts (4)
15-16: Correctly import new error types.The import statements for
InvalidMaxFeePerGasErrorandInvalidMaxPriorityFeePerGasErrorare correctly added to support the new validation logic.
103-103: Add tests for new parameters in valid scenarios.The addition of
maxFeePerGasandmaxPriorityFeePerGasto the test cases for valid parameters is correctly implemented, ensuring that these new fields are tested under expected conditions.Also applies to: 140-140
163-164: Add tests for new parameters in invalid scenarios.The inclusion of test cases for invalid
maxFeePerGasandmaxPriorityFeePerGasvalues is crucial for ensuring robust parameter validation.
200-201: Ensure new errors are caught in tests.The tests correctly check for instances of
InvalidMaxFeePerGasErrorandInvalidMaxPriorityFeePerGasError, which is essential for robust error handling.packages/actions/src/Call/callHandler.js (3)
Line range hint
209-222: Integrate the new EIP-1559 parametersmaxFeePerGasandmaxPriorityFeePerGasinto transaction creation.The addition of
maxFeePerGasandmaxPriorityFeePerGasparameters in the transaction creation process aligns with the EIP-1559 standards, allowing dynamic fee management. Ensure that all dependent functions correctly handle these new parameters.
230-230: Handle low gas price error effectively.The addition of error handling for scenarios where the gas price is too low is crucial for maintaining transaction integrity and preventing transactions from being stuck due to insufficient gas fees.
446-452: Ensure transaction creation respects the new EIP-1559 parameters.Properly passing
maxPriorityFeePerGasandmaxFeePerGasto thecreateTransactionfunction ensures that these parameters are respected during transaction creation, aligning with the EIP-1559 features.
| export * from './InvalidMaxFeePerGaserror.js' | ||
| export * from './InvalidMaxPriorityFeePerGas.js' |
There was a problem hiding this comment.
The export statements for InvalidMaxFeePerGasError and InvalidMaxPriorityFeePerGasError are correctly added. However, there's a typographical error in the file name InvalidMaxFeePerGaserror.js. It should be InvalidMaxFeePerGasError.js to maintain consistency and case sensitivity.
- export * from './InvalidMaxFeePerGaserror.js'
+ export * from './InvalidMaxFeePerGasError.js'Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| export * from './InvalidMaxFeePerGaserror.js' | |
| export * from './InvalidMaxPriorityFeePerGas.js' | |
| export * from './InvalidMaxFeePerGasError.js' | |
| export * from './InvalidMaxPriorityFeePerGas.js' |
| /** | ||
| * The maximum fee per gas for the EIP-1559 tx. This is the maximum amount of ether that can be spent on gas | ||
| * for the call. This is the maximum amount of ether that can be spent on gas for the call. | ||
| * This is the maximum amount of ether that can be spent on gas for the call. | ||
| */ | ||
| readonly maxFeePerGas?: bigint | ||
| /** | ||
| * The maximum priority fee per gas for the EIP-1559 tx. | ||
| */ | ||
| readonly maxPriorityFeePerGas?: bigint |
There was a problem hiding this comment.
Ensure consistency in the description of new parameters.
The descriptions for maxFeePerGas and maxPriorityFeePerGas are somewhat redundant. Consider simplifying to improve clarity and reduce repetition.
- The maximum fee per gas for the EIP-1559 tx. This is the maximum amount of ether that can be spent on gas for the call. This is the maximum amount of ether that can be spent on gas for the call. This is the maximum amount of ether that can be spent on gas for the call.
+ The maximum fee per gas for the EIP-1559 tx, representing the total amount of ether that can be spent on gas.Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| /** | |
| * The maximum fee per gas for the EIP-1559 tx. This is the maximum amount of ether that can be spent on gas | |
| * for the call. This is the maximum amount of ether that can be spent on gas for the call. | |
| * This is the maximum amount of ether that can be spent on gas for the call. | |
| */ | |
| readonly maxFeePerGas?: bigint | |
| /** | |
| * The maximum priority fee per gas for the EIP-1559 tx. | |
| */ | |
| readonly maxPriorityFeePerGas?: bigint | |
| /** | |
| * The maximum fee per gas for the EIP-1559 tx, representing the total amount of ether that can be spent on gas. | |
| */ | |
| readonly maxFeePerGas?: bigint | |
| /** | |
| * The maximum priority fee per gas for the EIP-1559 tx. | |
| */ | |
| readonly maxPriorityFeePerGas?: bigint |
| ### maxFeePerGas? | ||
|
|
||
| > `optional` `readonly` **maxFeePerGas**: `bigint` | ||
|
|
||
| The maximum fee per gas for the EIP-1559 tx. This is the maximum amount of ether that can be spent on gas | ||
| for the call. This is the maximum amount of ether that can be spent on gas for the call. | ||
| This is the maximum amount of ether that can be spent on gas for the call. | ||
|
|
||
| ### maxPriorityFeePerGas? | ||
|
|
||
| > `optional` `readonly` **maxPriorityFeePerGas**: `bigint` | ||
|
|
||
| The maximum priority fee per gas for the EIP-1559 tx. | ||
|
|
There was a problem hiding this comment.
Clarify documentation for new parameters.
The documentation for maxFeePerGas and maxPriorityFeePerGas is verbose and repetitive. Simplify the text to enhance readability and clarity.
- The maximum fee per gas for the EIP-1559 tx. This is the maximum amount of ether that can be spent on gas for the call. This is the maximum amount of ether that can be spent on gas for the call. This is the maximum amount of ether that can be spent on gas for the call.
+ The maximum fee per gas for the EIP-1559 tx, representing the total amount of ether that can be spent on gas.Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| ### maxFeePerGas? | |
| > `optional` `readonly` **maxFeePerGas**: `bigint` | |
| The maximum fee per gas for the EIP-1559 tx. This is the maximum amount of ether that can be spent on gas | |
| for the call. This is the maximum amount of ether that can be spent on gas for the call. | |
| This is the maximum amount of ether that can be spent on gas for the call. | |
| ### maxPriorityFeePerGas? | |
| > `optional` `readonly` **maxPriorityFeePerGas**: `bigint` | |
| The maximum priority fee per gas for the EIP-1559 tx. | |
| ### maxFeePerGas? | |
| > `optional` `readonly` **maxFeePerGas**: `bigint` | |
| The maximum fee per gas for the EIP-1559 tx, representing the total amount of ether that can be spent on gas. | |
| ### maxPriorityFeePerGas? | |
| > `optional` `readonly` **maxPriorityFeePerGas**: `bigint` | |
| The maximum priority fee per gas for the EIP-1559 tx. |
Tools
LanguageTool
[style] ~152-~152: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym. (ENGLISH_WORD_REPEAT_BEGINNING_RULE)
Context: ... that can be spent on gas for the call. This is the maximum amount of ether that can...
roninjin10
force-pushed
the
06-13-_sparkles_feat_add_maxpriorityfeepergas_and_maxfeepergas
branch
from
315af5f
to
366a900
Compare
There was a problem hiding this comment.
Actionable comments posted: 9
Outside diff range and nitpick comments (14)
packages/errors/docs/classes/InvalidParamsError.md (2)
Line range hint
30-30: Remove duplicate headings to maintain document clarity.- ## Param
Line range hint
285-285: Enclose the URL in angle brackets to prevent it from being interpreted as plain text.- https://v8.dev/docs/stack-trace-api#customizing-stack-traces + <https://v8.dev/docs/stack-trace-api#customizing-stack-traces>packages/errors/docs/classes/InvalidMaxPriorityFeePerGasError.md (3)
30-30: Consider consolidating theParamsections to avoid duplicate headings.## Param - A human-readable error message. - Additional parameters for the InvalidMaxPriorityFeePerGasError.Tools
Markdownlint
30-30: null (MD024, no-duplicate-heading)
Multiple headings with the same content
350-350: Check if the duplicate heading forcaptureStackTraceis necessary or if it can be combined into a single section.### captureStackTrace(targetObject, constructorOpt) > `static` **captureStackTrace**(`targetObject`, `constructorOpt`?): `void` Create .stack property on a target object ##### Parameters • **targetObject**: `object` • **constructorOpt?**: `Function` ##### Returns `void` ##### Inherited from [`InvalidParamsError`](InvalidParamsError.md).[`captureStackTrace`](InvalidParamsError.md#capturestacktrace) ##### Source node_modules/.pnpm/[email protected]/node_modules/bun-types/globals.d.ts:1613Tools
Markdownlint
350-350: null (MD024, no-duplicate-heading)
Multiple headings with the same content
260-260: Please wrap the bare URL with angle brackets to adhere to Markdown best practices.#### See <https://v8.dev/docs/stack-trace-api#customizing-stack-traces>Tools
Markdownlint
260-260: null (MD034, no-bare-urls)
Bare URL useddocs/src/content/docs/reference/@tevm/errors/classes/InvalidParamsError.md (3)
Line range hint
29-29: Consider consolidating theParamsections to avoid duplicate headings.## Param - A human-readable error message. - Additional parameters for the BaseError.
Line range hint
374-374: Check if the duplicate heading forcaptureStackTraceis necessary or if it can be combined into a single section.### captureStackTrace(targetObject, constructorOpt) > `static` **captureStackTrace**(`targetObject`, `constructorOpt`?): `void` Create .stack property on a target object ##### Parameters • **targetObject**: `object` • **constructorOpt?**: `Function` ##### Returns `void` ##### Inherited from [`BaseError`](/reference/tevm/errors/classes/baseerror/).[`captureStackTrace`](/reference/tevm/errors/classes/baseerror/#capturestacktrace) ##### Source node_modules/.pnpm/[email protected]/node_modules/bun-types/globals.d.ts:1613
Line range hint
284-284: Please wrap the bare URL with angle brackets to adhere to Markdown best practices.#### See <https://v8.dev/docs/stack-trace-api#customizing-stack-traces>docs/src/content/docs/reference/@tevm/errors/classes/InvalidMaxFeePerGasError.md (3)
29-29: Consider consolidating theParamsections to avoid duplicate headings.## Param - A human-readable error message. - Additional parameters for the InvalidMaxFeePerGasError.Tools
Markdownlint
29-29: null (MD024, no-duplicate-heading)
Multiple headings with the same content
349-349: Check if the duplicate heading forcaptureStackTraceis necessary or if it can be combined into a single section.### captureStackTrace(targetObject, constructorOpt) > `static` **captureStackTrace**(`targetObject`, `constructorOpt`?): `void` Create .stack property on a target object ##### Parameters • **targetObject**: `object` • **constructorOpt?**: `Function` ##### Returns `void` ##### Inherited from [`InvalidParamsError`](/reference/tevm/errors/classes/invalidparamserror/).[`captureStackTrace`](/reference/tevm/errors/classes/invalidparamserror/#capturestacktrace) ##### Source node_modules/.pnpm/[email protected]/node_modules/bun-types/globals.d.ts:1613Tools
Markdownlint
349-349: null (MD024, no-duplicate-heading)
Multiple headings with the same content
259-259: Please wrap the bare URL with angle brackets to adhere to Markdown best practices.#### See <https://v8.dev/docs/stack-trace-api#customizing-stack-traces>Tools
Markdownlint
259-259: null (MD034, no-bare-urls)
Bare URL useddocs/src/content/docs/reference/@tevm/errors/classes/InvalidMaxPriorityFeePerGasError.md (3)
29-29: Consider consolidating theParamsections to avoid duplicate headings.## Param - A human-readable error message. - Additional parameters for the InvalidMaxPriorityFeePerGasError.Tools
Markdownlint
29-29: null (MD024, no-duplicate-heading)
Multiple headings with the same content
349-349: Check if the duplicate heading forcaptureStackTraceis necessary or if it can be combined into a single section.### captureStackTrace(targetObject, constructorOpt) > `static` **captureStackTrace**(`targetObject`, `constructorOpt`?): `void` Create .stack property on a target object ##### Parameters • **targetObject**: `object` • **constructorOpt?**: `Function` ##### Returns `void` ##### Inherited from [`InvalidParamsError`](/reference/tevm/errors/classes/invalidparamserror/).[`captureStackTrace`](/reference/tevm/errors/classes/invalidparamserror/#capturestacktrace) ##### Source node_modules/.pnpm/[email protected]/node_modules/bun-types/globals.d.ts:1613Tools
Markdownlint
349-349: null (MD024, no-duplicate-heading)
Multiple headings with the same content
259-259: Please wrap the bare URL with angle brackets to adhere to Markdown best practices.#### See <https://v8.dev/docs/stack-trace-api#customizing-stack-traces>Tools
Markdownlint
259-259: null (MD034, no-bare-urls)
Bare URL used
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files ignored due to path filters (1)
bundler-packages/resolutions/src/__snapshots__/moduleFactory.spec.ts.snapis excluded by!**/*.snap
Files selected for processing (25)
- docs/src/content/docs/reference/@tevm/actions/functions/validateBaseCallParams-1.md (1 hunks)
- docs/src/content/docs/reference/@tevm/actions/functions/validateBaseCallParams.md (1 hunks)
- docs/src/content/docs/reference/@tevm/actions/type-aliases/BaseCallParams-1.md (2 hunks)
- docs/src/content/docs/reference/@tevm/actions/type-aliases/BaseCallParams.md (2 hunks)
- docs/src/content/docs/reference/@tevm/errors/classes/InvalidMaxFeePerGasError.md (1 hunks)
- docs/src/content/docs/reference/@tevm/errors/classes/InvalidMaxPriorityFeePerGasError.md (1 hunks)
- docs/src/content/docs/reference/@tevm/errors/classes/InvalidParamsError.md (1 hunks)
- docs/src/content/docs/reference/@tevm/errors/globals.md (2 hunks)
- docs/src/content/docs/reference/@tevm/errors/interfaces/InvalidMaxFeePerGasErrorParameters.md (1 hunks)
- docs/src/content/docs/reference/@tevm/errors/interfaces/InvalidMaxPriorityFeePerGasErrorParameters.md (1 hunks)
- packages/actions/docs/functions/validateBaseCallParams.md (1 hunks)
- packages/actions/src/BaseCall/validateBaseCallParams.js (2 hunks)
- packages/actions/src/BaseCall/validateBaseCallParams.spec.ts (5 hunks)
- packages/errors/docs/classes/InvalidMaxFeePerGasError.md (1 hunks)
- packages/errors/docs/classes/InvalidMaxPriorityFeePerGasError.md (1 hunks)
- packages/errors/docs/classes/InvalidParamsError.md (1 hunks)
- packages/errors/docs/globals.md (2 hunks)
- packages/errors/docs/interfaces/InvalidMaxFeePerGasErrorParameters.md (1 hunks)
- packages/errors/docs/interfaces/InvalidMaxPriorityFeePerGasErrorParameters.md (1 hunks)
- tevm/docs/errors/README.md (2 hunks)
- tevm/docs/errors/classes/InvalidMaxFeePerGasError.md (1 hunks)
- tevm/docs/errors/classes/InvalidMaxPriorityFeePerGasError.md (1 hunks)
- tevm/docs/errors/classes/InvalidParamsError.md (1 hunks)
- tevm/docs/errors/type-aliases/InvalidMaxFeePerGasErrorParameters.md (1 hunks)
- tevm/docs/errors/type-aliases/InvalidMaxPriorityFeePerGasErrorParameters.md (1 hunks)
Files skipped from review due to trivial changes (5)
- docs/src/content/docs/reference/@tevm/errors/interfaces/InvalidMaxPriorityFeePerGasErrorParameters.md
- packages/actions/src/BaseCall/validateBaseCallParams.js
- packages/errors/docs/interfaces/InvalidMaxPriorityFeePerGasErrorParameters.md
- tevm/docs/errors/type-aliases/InvalidMaxFeePerGasErrorParameters.md
- tevm/docs/errors/type-aliases/InvalidMaxPriorityFeePerGasErrorParameters.md
Files skipped from review as they are similar to previous changes (1)
- packages/actions/src/BaseCall/validateBaseCallParams.spec.ts
Additional context used
LanguageTool
docs/src/content/docs/reference/@tevm/actions/functions/validateBaseCallParams.md
[uncategorized] ~12-~12: Possible missing comma found. (AI_HYDRA_LEO_MISSING_COMMA)
Context: ...lidateBaseCallParamsError`[] can break on a minor release Validates that the para...docs/src/content/docs/reference/@tevm/actions/functions/validateBaseCallParams-1.md
[uncategorized] ~12-~12: Possible missing comma found. (AI_HYDRA_LEO_MISSING_COMMA)
Context: ...lidateBaseCallParamsError`[] can break on a minor release Validates that the para...packages/actions/docs/functions/validateBaseCallParams.md
[uncategorized] ~13-~13: Possible missing comma found. (AI_HYDRA_LEO_MISSING_COMMA)
Context: ...lidateBaseCallParamsError`[] can break on a minor release Validates that the para...docs/src/content/docs/reference/@tevm/actions/type-aliases/BaseCallParams.md
[uncategorized] ~30-~30: It seems likely that a singular genitive (’s) apostrophe is missing. (AI_HYDRA_LEO_APOSTROPHE_S_XS)
Context: ...ock will not run in the context of that blocks state. To do that fork that block numbe...
[uncategorized] ~30-~30: Possible missing comma found. (AI_HYDRA_LEO_MISSING_COMMA)
Context: ...the context of that blocks state. To do that fork that block number first. #### Exa...
[style] ~89-~89: Consider shortening this phrase to just ‘whether’, unless you mean ‘regardless of whether’. (WHETHER)
Context: ...|"always"|"never"|booleanWhether or not to update the state or run call in a dr...
[style] ~95-~95: The adverb ‘Always’ is usually put between ‘will’ and ‘still’. (ADVERB_WORD_ORDER)
Context: ...n-success-false: alias fornever` Always will still not include the transaction if it's not...
[uncategorized] ~97-~97: Possible missing comma found. (AI_HYDRA_LEO_MISSING_COMMA)
Context: ...if it's not valid to be included in the chain such as the gas limit being too low. If...
[grammar] ~98-~98: The usual collocation for “returned” is “to”, not “in”. (RETURN_IN_THE)
Context: ... a tx is submitted thetxHashwill be returned in the response. The tx will not be includ...
[uncategorized] ~112-~112: If this is a compound adjective that modifies the following noun, use a hyphen. (EN_COMPOUND_ADJECTIVE_INTERNAL)
Context: ...tionalreadonly**depth**:number` Low level control over the EVM call depth. Useful...
[uncategorized] ~122-~122: A comma may be missing after the conjunctive/linking adverb ‘Otherwise’. (SENT_START_CONJUNCTIVE_LINKING_ADVERB_COMMA)
Context: ...dresses seperately using those options. Otherwise both are set to thefromaddress ###...
[uncategorized] ~142-~142: If this is a compound adjective that modifies the following noun, use a hyphen. (EN_COMPOUND_ADJECTIVE_INTERNAL)
Context: ...alreadonly**gasRefund**:bigintLow level control Refund counter. Defaults to0`...
[style] ~151-~151: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym. (ENGLISH_WORD_REPEAT_BEGINNING_RULE)
Context: ... that can be spent on gas for the call. This is the maximum amount of ether that can...
[typographical] ~165-~165: The word “otherwise” is an adverb that can’t be used like a conjunction, and therefore needs to be separated from the sentence. (THUS_SENTENCE)
Context: ...ess. This defaults tofromaddress if set otherwise it defaults to the zero address ### se...
[style] ~185-~185: ‘prior to’ might be wordy. Consider a shorter alternative. (EN_WORDINESS_PREMIUM_PRIOR_TO)
Context: ...some state to be ephemerally overridden prior to executing the call. Each address maps t...
[grammar] ~190-~190: One modal verb seems to be obsolete here. Consider rephrasing this sentence. (DO_XX_MD_VB)
Context: ...e that simply returns internal state or does pre-defined validations can be kept off chain and fed to the node o...docs/src/content/docs/reference/@tevm/actions/type-aliases/BaseCallParams-1.md
[uncategorized] ~30-~30: It seems likely that a singular genitive (’s) apostrophe is missing. (AI_HYDRA_LEO_APOSTROPHE_S_XS)
Context: ...ock will not run in the context of that blocks state. To do that fork that block numbe...
[uncategorized] ~30-~30: Possible missing comma found. (AI_HYDRA_LEO_MISSING_COMMA)
Context: ...the context of that blocks state. To do that fork that block number first. #### Exa...
[style] ~89-~89: Consider shortening this phrase to just ‘whether’, unless you mean ‘regardless of whether’. (WHETHER)
Context: ...|"always"|"never"|booleanWhether or not to update the state or run call in a dr...
[style] ~95-~95: The adverb ‘Always’ is usually put between ‘will’ and ‘still’. (ADVERB_WORD_ORDER)
Context: ...n-success-false: alias fornever` Always will still not include the transaction if it's not...
[uncategorized] ~97-~97: Possible missing comma found. (AI_HYDRA_LEO_MISSING_COMMA)
Context: ...if it's not valid to be included in the chain such as the gas limit being too low. If...
[grammar] ~98-~98: The usual collocation for “returned” is “to”, not “in”. (RETURN_IN_THE)
Context: ... a tx is submitted thetxHashwill be returned in the response. The tx will not be includ...
[uncategorized] ~112-~112: If this is a compound adjective that modifies the following noun, use a hyphen. (EN_COMPOUND_ADJECTIVE_INTERNAL)
Context: ...tionalreadonly**depth**:number` Low level control over the EVM call depth. Useful...
[uncategorized] ~122-~122: A comma may be missing after the conjunctive/linking adverb ‘Otherwise’. (SENT_START_CONJUNCTIVE_LINKING_ADVERB_COMMA)
Context: ...dresses seperately using those options. Otherwise both are set to thefromaddress ###...
[uncategorized] ~142-~142: If this is a compound adjective that modifies the following noun, use a hyphen. (EN_COMPOUND_ADJECTIVE_INTERNAL)
Context: ...alreadonly**gasRefund**:bigintLow level control Refund counter. Defaults to0`...
[style] ~151-~151: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym. (ENGLISH_WORD_REPEAT_BEGINNING_RULE)
Context: ... that can be spent on gas for the call. This is the maximum amount of ether that can...
[typographical] ~165-~165: The word “otherwise” is an adverb that can’t be used like a conjunction, and therefore needs to be separated from the sentence. (THUS_SENTENCE)
Context: ...ess. This defaults tofromaddress if set otherwise it defaults to the zero address ### se...
[style] ~185-~185: ‘prior to’ might be wordy. Consider a shorter alternative. (EN_WORDINESS_PREMIUM_PRIOR_TO)
Context: ...some state to be ephemerally overridden prior to executing the call. Each address maps t...
[grammar] ~190-~190: One modal verb seems to be obsolete here. Consider rephrasing this sentence. (DO_XX_MD_VB)
Context: ...e that simply returns internal state or does pre-defined validations can be kept off chain and fed to the node o...
Markdownlint
tevm/docs/errors/classes/InvalidParamsError.md
30-30: null (MD024, no-duplicate-heading)
Multiple headings with the same content
375-375: null (MD024, no-duplicate-heading)
Multiple headings with the same content
285-285: null (MD034, no-bare-urls)
Bare URL useddocs/src/content/docs/reference/@tevm/actions/type-aliases/BaseCallParams.md
11-11: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines
91-91: null (MD032, blanks-around-lists)
Lists should be surrounded by blank linesdocs/src/content/docs/reference/@tevm/actions/type-aliases/BaseCallParams-1.md
11-11: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines
91-91: null (MD032, blanks-around-lists)
Lists should be surrounded by blank linestevm/docs/errors/classes/InvalidMaxFeePerGasError.md
30-30: null (MD024, no-duplicate-heading)
Multiple headings with the same content
350-350: null (MD024, no-duplicate-heading)
Multiple headings with the same content
260-260: null (MD034, no-bare-urls)
Bare URL usedtevm/docs/errors/classes/InvalidMaxPriorityFeePerGasError.md
30-30: null (MD024, no-duplicate-heading)
Multiple headings with the same content
350-350: null (MD024, no-duplicate-heading)
Multiple headings with the same content
260-260: null (MD034, no-bare-urls)
Bare URL usedpackages/errors/docs/classes/InvalidParamsError.md
30-30: null (MD024, no-duplicate-heading)
Multiple headings with the same content
375-375: null (MD024, no-duplicate-heading)
Multiple headings with the same content
285-285: null (MD034, no-bare-urls)
Bare URL usedpackages/errors/docs/classes/InvalidMaxFeePerGasError.md
30-30: null (MD024, no-duplicate-heading)
Multiple headings with the same content
350-350: null (MD024, no-duplicate-heading)
Multiple headings with the same content
260-260: null (MD034, no-bare-urls)
Bare URL usedpackages/errors/docs/classes/InvalidMaxPriorityFeePerGasError.md
30-30: null (MD024, no-duplicate-heading)
Multiple headings with the same content
350-350: null (MD024, no-duplicate-heading)
Multiple headings with the same content
260-260: null (MD034, no-bare-urls)
Bare URL useddocs/src/content/docs/reference/@tevm/errors/classes/InvalidParamsError.md
29-29: null (MD024, no-duplicate-heading)
Multiple headings with the same content
374-374: null (MD024, no-duplicate-heading)
Multiple headings with the same content
284-284: null (MD034, no-bare-urls)
Bare URL useddocs/src/content/docs/reference/@tevm/errors/classes/InvalidMaxFeePerGasError.md
29-29: null (MD024, no-duplicate-heading)
Multiple headings with the same content
349-349: null (MD024, no-duplicate-heading)
Multiple headings with the same content
259-259: null (MD034, no-bare-urls)
Bare URL useddocs/src/content/docs/reference/@tevm/errors/classes/InvalidMaxPriorityFeePerGasError.md
29-29: null (MD024, no-duplicate-heading)
Multiple headings with the same content
349-349: null (MD024, no-duplicate-heading)
Multiple headings with the same content
259-259: null (MD034, no-bare-urls)
Bare URL used
Additional comments not posted (11)
docs/src/content/docs/reference/@tevm/actions/functions/validateBaseCallParams.md (1)
25-25: Check the source link accuracy and ensure it points to the correct line in the codebase reflecting the latest changes.Verification successful
The documentation link correctly points to the line where the
validateBaseCallParamsfunction is defined.
- Location:
docs/src/content/docs/reference/@tevm/actions/functions/validateBaseCallParams.md- Code:
[packages/actions/src/BaseCall/validateBaseCallParams.js:32](https://github.com/evmts/tevm-monorepo/blob/main/packages/actions/src/BaseCall/validateBaseCallParams.js#L32)Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify that the source link points to the correct line number in the validateBaseCallParams.js file. # Expected: Link points to the exact line where the function is defined or modified. cat packages/actions/src/BaseCall/validateBaseCallParams.js | sed -n 32pLength of output: 126
docs/src/content/docs/reference/@tevm/actions/functions/validateBaseCallParams-1.md (1)
25-25: Confirm the necessity of this file in the documentation structure, as it appears similar tovalidateBaseCallParams.md.packages/actions/docs/functions/validateBaseCallParams.md (1)
26-26: Check the source link accuracy and ensure it points to the correct line in the codebase reflecting the latest changes.Verification successful
The source link in the documentation correctly points to the line where the
validateBaseCallParamsfunction is defined.
- The link points to line 32 of
validateBaseCallParams.js, which is where the function is exported.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify that the source link points to the correct line number in the validateBaseCallParams.js file. # Expected: Link points to the exact line where the function is defined or modified. cat packages/actions/src/BaseCall/validateBaseCallParams.js | sed -n 32pLength of output: 126
docs/src/content/docs/reference/@tevm/errors/interfaces/InvalidMaxFeePerGasErrorParameters.md (1)
12-12: Clarify the type ofcausein the documentation to ensure it aligns with the implementation in the source code.Verification successful
The
BaseErrorclass was successfully located, and it indeed takes anargsparameter which can include acauseproperty. This aligns with the documentation stating thatcausecan beundefined,BaseError, orError.
packages/errors/src/ethereum/BaseError.jsexperimental/viem-effect/src-viem/errors/base.tsThe documentation for
InvalidMaxFeePerGasErroris accurate with respect to the type ofcause.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the type of `cause` in the InvalidMaxFeePerGasError class implementation. # Expected: Type of `cause` matches the documentation. ast-grep --lang javascript --pattern $'class InvalidMaxFeePerGasError { constructor($_, $_) { this.cause = $_ } }'Length of output: 123
Script:
#!/bin/bash # Locate the InvalidMaxFeePerGasError class and inspect its constructor to verify the type of `cause`. ast-grep --lang javascript --pattern 'class InvalidMaxFeePerGasError { constructor($$$) { $$$ } }'Length of output: 108
Script:
#!/bin/bash # Search for the InvalidMaxFeePerGasError class definition in the entire repository and extract relevant details. rg 'class InvalidMaxFeePerGasError' --context 10Length of output: 2348
Script:
#!/bin/bash # Locate the InvalidParamsError class and inspect its constructor to verify how args and cause are handled. rg 'class InvalidParamsError' --context 10Length of output: 2154
Script:
#!/bin/bash # Locate the BaseError class and inspect its constructor to verify how args and cause are handled. rg 'class BaseError' --context 10Length of output: 7052
tevm/docs/errors/classes/InvalidParamsError.md (1)
62-63: The addition ofInvalidMaxFeePerGasErrorandInvalidMaxPriorityFeePerGasErrorto the list of extended errors is appropriate given the context of handling new types of transaction errors in EIP-1559.docs/src/content/docs/reference/@tevm/actions/type-aliases/BaseCallParams.md (1)
136-137: Clarify the documentation around thegasPricebeing ignored in the context of EIP-1559 transactions. It might be helpful to explain why this behavior occurs and under what conditions thegasPricewill be considered again.packages/errors/docs/globals.md (2)
64-65: The addition ofInvalidMaxFeePerGasErrorandInvalidMaxPriorityFeePerGasErrorto the error classes list is consistent with the PR's objectives to handle new error types for EIP-1559 transaction parameters.
165-166: The corresponding parameters for the new error classesInvalidMaxFeePerGasErrorParametersandInvalidMaxPriorityFeePerGasErrorParametershave been correctly added. This ensures that the error handling is robust and can be customized based on the error context.tevm/docs/errors/README.md (1)
68-69: The new error classesInvalidMaxFeePerGasErrorandInvalidMaxPriorityFeePerGasErrorhave been added to the index. This ensures users can easily find documentation related to these new errors introduced for handling EIP-1559 transaction parameters.docs/src/content/docs/reference/@tevm/errors/globals.md (2)
65-66: The addition ofInvalidMaxFeePerGasErrorandInvalidMaxPriorityFeePerGasErrorto the list of error classes is well-documented. This update is crucial for developers to understand the new error types associated with EIP-1559 features.
166-167: The parameters for the new error classes,InvalidMaxFeePerGasErrorParametersandInvalidMaxPriorityFeePerGasErrorParameters, have been correctly documented. This detailed documentation is essential for developers to implement and handle these errors appropriately.
roninjin10
deleted the
06-13-_sparkles_feat_add_maxpriorityfeepergas_and_maxfeepergas
branch
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.⚠️ ⚠️ ⚠️ ⚠️ ⚠️ ⚠️ `main` is currently in **pre mode** so this branch has prereleases rather than normal releases. If you want to exit prereleases, run `changeset pre exit` on `main`.⚠️ ⚠️ ⚠️ ⚠️ ⚠️ ⚠️ # Releases ## @tevm/[email protected] ### Minor Changes - [#1198](#1198) [`4650d32`](4650d32) Thanks [@roninjin10](https://github.com/roninjin10)! - Added support for setting maxFeePerGas and maxPriorityFeePerGas - [#1198](#1198) [`4650d32`](4650d32) Thanks [@roninjin10](https://github.com/roninjin10)! - Added support for passing in maxFeePerGas and maxPriorityFeePerGas to tevmCall tevmContract tevmDeploy and tevmScript ### Patch Changes - [#1197](#1197) [`fbf5192`](fbf5192) Thanks [@roninjin10](https://github.com/roninjin10)! - Fixed bug where tevmCall and related methods would improperly validate params such as depth and value. Previously it would not throw a validation error if these numbers are negative - [#1197](#1197) [`fbf5192`](fbf5192) Thanks [@roninjin10](https://github.com/roninjin10)! - Fixed bug where validation errors of nested structures like arrays would sometimes get swallowed by tevmCall and related methods - Updated dependencies \[[`4650d32`](4650d32)]: - @tevm/[email protected] - @tevm/[email protected] - @tevm/[email protected] - @tevm/[email protected] - @tevm/[email protected] - @tevm/[email protected] - @tevm/[email protected] ## @tevm/[email protected] ### Minor Changes - [#1198](#1198) [`4650d32`](4650d32) Thanks [@roninjin10](https://github.com/roninjin10)! - Added support for setting maxFeePerGas and maxPriorityFeePerGas ## @tevm/[email protected] ### Minor Changes - [#1198](#1198) [`4650d32`](4650d32) Thanks [@roninjin10](https://github.com/roninjin10)! - Added support for setting maxFeePerGas and maxPriorityFeePerGas ### Patch Changes - Updated dependencies \[[`4650d32`](4650d32)]: - @tevm/[email protected] - @tevm/[email protected] - @tevm/[email protected] - @tevm/[email protected] ## @tevm/[email protected] ### Patch Changes - Updated dependencies \[]: - @tevm/[email protected] - @tevm/[email protected] - @tevm/[email protected] - @tevm/[email protected] ## @tevm/[email protected] ### Patch Changes - Updated dependencies \[]: - @tevm/[email protected] - @tevm/[email protected] ## @tevm/[email protected] ### Patch Changes - Updated dependencies \[[`4650d32`](4650d32)]: - @tevm/[email protected] - @tevm/[email protected] - @tevm/[email protected] - @tevm/[email protected] - @tevm/[email protected] - @tevm/[email protected] - @tevm/[email protected] ## @tevm/[email protected] ### Patch Changes - Updated dependencies \[[`4650d32`](4650d32)]: - @tevm/[email protected] ## @tevm/[email protected] ### Patch Changes - Updated dependencies \[]: - @tevm/[email protected] ## @tevm/[email protected] ### Patch Changes - Updated dependencies \[[`4650d32`](4650d32), [`4650d32`](4650d32), [`fbf5192`](fbf5192), [`fbf5192`](fbf5192)]: - @tevm/[email protected] - @tevm/[email protected] - @tevm/[email protected] ## @tevm/[email protected] ### Patch Changes - Updated dependencies \[]: - @tevm/[email protected] ## @tevm/[email protected] ### Patch Changes - Updated dependencies \[]: - @tevm/[email protected] - @tevm/[email protected] ## @tevm/[email protected] ### Patch Changes - Updated dependencies \[]: - @tevm/[email protected] - @tevm/[email protected] - @tevm/[email protected] - @tevm/[email protected] ## @tevm/[email protected] ### Patch Changes - Updated dependencies \[]: - @tevm/[email protected] - @tevm/[email protected] ## @tevm/[email protected] ### Patch Changes - Updated dependencies \[[`4650d32`](4650d32), [`4650d32`](4650d32), [`fbf5192`](fbf5192), [`fbf5192`](fbf5192)]: - @tevm/[email protected] - @tevm/[email protected] - @tevm/[email protected] - @tevm/[email protected] - @tevm/[email protected] - @tevm/[email protected] ## @tevm/[email protected] ### Patch Changes - Updated dependencies \[[`4650d32`](4650d32)]: - @tevm/[email protected] - @tevm/[email protected] - @tevm/[email protected] ## @tevm/[email protected] ### Patch Changes - Updated dependencies \[]: - @tevm/[email protected] ## @tevm/[email protected] ### Patch Changes - Updated dependencies \[[`4650d32`](4650d32)]: - @tevm/[email protected] - @tevm/[email protected] - @tevm/[email protected] ## [email protected] ### Patch Changes - [#1195](#1195) [`c58a6e5`](c58a6e5) Thanks [@roninjin10](https://github.com/roninjin10)! - Fixed bug with bad export" - Updated dependencies \[[`4650d32`](4650d32), [`4650d32`](4650d32), [`fbf5192`](fbf5192), [`fbf5192`](fbf5192)]: - @tevm/[email protected] - @tevm/[email protected] - @tevm/[email protected] - @tevm/[email protected] - @tevm/[email protected] - @tevm/[email protected] - @tevm/[email protected] - @tevm/[email protected] - @tevm/[email protected] - @tevm/[email protected] Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Description
Concise description of proposed changes
Testing
Explain the quality checks that have been done on the code changes
Additional Information
Your ENS/address:
Summary by CodeRabbit
New Features
maxFeePerGasandmaxPriorityFeePerGasfor EIP-1559 transactions across various modules.Documentation
maxFeePerGasandmaxPriorityFeePerGas.InvalidMaxFeePerGasErrorandInvalidMaxPriorityFeePerGasError.Bug Fixes
Tests
maxFeePerGasandmaxPriorityFeePerGas.