-
-
Notifications
You must be signed in to change notification settings - Fork 26
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
## Description _Concise description of proposed changes_ ## Testing Explain the quality checks that have been done on the code changes ## Additional Information - [ ] I read the [contributing docs](../docs/contributing.md) (if this is your first contribution) Your ENS/address: <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Bug Fixes** - Resolved parameter validation issues in `tevmCall` and related methods, ensuring nested structures like arrays are validated correctly. - **Documentation** - Added detailed documentation and examples for various parameters in `BaseCallParams` to improve clarity and usability. - **Tests** - Introduced new test cases for validating base call parameters to ensure correctness. - **Refactor** - Updated validation constraints for `gasRefund`, `gas`, `value`, and `depth` parameters to ensure they are positive values. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Co-authored-by: William Cory <[email protected]>
- Loading branch information
1 parent
c58a6e5
commit fbf5192
Showing
16 changed files
with
571 additions
and
293 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
--- | ||
"@tevm/actions": patch | ||
--- | ||
|
||
Fixed bug where tevmCall and related methods would improperly validate params such as depth and value. Previously it would not throw a validation error if these numbers are negative |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
--- | ||
"@tevm/actions": patch | ||
--- | ||
|
||
Fixed bug where validation errors of nested structures like arrays would sometimes get swallowed by tevmCall and related methods |
7 changes: 6 additions & 1 deletion
7
.../src/content/docs/reference/@tevm/actions/functions/validateBaseCallParams-1.md
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
7 changes: 6 additions & 1 deletion
7
docs/src/content/docs/reference/@tevm/actions/functions/validateBaseCallParams.md
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
61 changes: 51 additions & 10 deletions
61
docs/src/content/docs/reference/@tevm/actions/type-aliases/BaseCallParams-1.md
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
61 changes: 51 additions & 10 deletions
61
docs/src/content/docs/reference/@tevm/actions/type-aliases/BaseCallParams.md
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Oops, something went wrong.