fix(ante): fix reCheckTx gas wanted

[GAtom22]

Closes:

• Issue #1554
• https://linear.app/evmos/issue/ENG-1238/bug-not-calling-runtxdelivermode-after-runtxrecheckmode

Description

Set gasWanted = 0 for Txs in ReCheckMode at the EthGasConsumeDecorator AnteHandler. Otherwise, Tendermint logs this error:

"gas wanted -1 is negative"

However, this error is not bubbled up and the Tx never runs on DeliverMode.

For more details, check the related issue's comments.

---

For contributor use:

• Targeted PR against correct branch (see CONTRIBUTING.md)
• Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
• Code follows the module structure standards.
• Wrote unit and integration tests
• Updated relevant documentation (docs/) or specification (x/<module>/spec/)
• Added relevant godoc comments.
• Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
• Re-reviewed Files changed in the Github PR explorer

---

For admin use:

• Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
• Reviewers assigned
• Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

[codecov]

Codecov Report

Merging #1566 (1692948) into main (0e366db) will increase coverage by 0.02%.
The diff coverage is 100.00%.

❗ Current head 1692948 differs from pull request most recent head b2e96e3. Consider uploading reports for the commit b2e96e3 to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1566      +/-   ##
==========================================
+ Coverage   68.63%   68.65%   +0.02%     
==========================================
  Files         103      103              
  Lines        9946     9953       +7     
==========================================
+ Hits         6826     6833       +7     
  Misses       2737     2737              
  Partials      383      383              

Impacted Files	Coverage Δ
app/ante/eth.go	80.00% <100.00%> (+0.64%)	⬆️

[fedekunze]

utACK. Is it possible to add a test or is this something that we need to flag on Tendermint?

Could you add a changelog entry?

[GAtom22]

utACK. Is it possible to add a test or is this something that we need to flag on Tendermint?

@fedekunze It's a little tricky to test it.. I'll try to write a test for this case.

IMO this error should be returned.. Maybe the fix would be to add it to the MempoolError field of the abci.ResponseCheckTx on the handleRecheckResult func. This is done on the addNewTransaction func (haven't tested if this solves the issue tho)