Skip to content
This repository has been archived by the owner on Apr 4, 2024. It is now read-only.

tests: make integration test more stable #1488

Merged
merged 41 commits into from
Dec 23, 2022
Merged

tests: make integration test more stable #1488

merged 41 commits into from
Dec 23, 2022

Conversation

mmsqe
Copy link
Contributor

@mmsqe mmsqe commented Nov 22, 2022 •
edited
Loading

Closes: #1487

Description

This PR mainly focus adjust mempool related config, also fix

  • zombie supervisor process left when exit status 1
  • panic in upgrade test after the remove migration which need upgrade version
  • miss retry like in test_grpc_only call
  • transaction is not in the chain due to failed re-CheckTx callback

For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@mmsqe mmsqe marked this pull request as ready for review November 24, 2022 01:14
@mmsqe mmsqe requested a review from a team as a code owner November 24, 2022 01:14
@mmsqe mmsqe requested review from GAtom22 and 4rgon4ut and removed request for a team November 24, 2022 01:14
@fedekunze fedekunze mentioned this pull request Nov 24, 2022
Closed
11 tasks
@fedekunze fedekunze added the Type: Tests issues and PR related to tests label Nov 24, 2022
@mmsqe mmsqe changed the title fix(tests): make integration test more stable tests: make integration test more stable Nov 28, 2022
mmsqe
mmsqe commented Dec 9, 2022
View reviewed changes
tests/integration_tests/test_grpc_only.py
@@ -45,9 +47,6 @@ def grpc_eth_call(port: int, args: dict, chain_id=None, proposer_address=None):
).json()


@pytest.mark.skip(
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@facs95 do you mind if I keep this, since I fail to reproduce when long run this test after seeing #1510 (comment), will be happy to help if there's bug hidden

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh yes sorry - This was already a fix by @ramacarlucho so we can delete the skip. It should fail randomly anymore 🙏

@mmsqe mmsqe requested review from fedekunze and facs95 and removed request for ramacarlucho, GAtom22 and fedekunze December 16, 2022 03:30
GAtom22
GAtom22 suggested changes Dec 22, 2022
View reviewed changes
Copy link
Contributor

@GAtom22 GAtom22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK! great work! left a couple of comments

tests/integration_tests/configs/default.jsonnet Outdated Show resolved Hide resolved
tests/integration_tests/test_upgrade.py Show resolved Hide resolved
mmsqe and others added 2 commits December 23, 2022 08:04
@mmsqe
Merge pull request #5 from GAtom22/add-recheck
7845edf 
tests(integration): enable recheck tx mode
@facs95
update gomod2nix
673093d
@GAtom22 GAtom22 self-requested a review December 23, 2022 12:33
@facs95
Copy link
Contributor

facs95 commented Dec 23, 2022

Thanks @mmsqe! And sorry for this to have taken this long 🙏

@facs95 facs95 merged commit 29caa19 into evmos:main Dec 23, 2022
@mmsqe
Copy link
Contributor Author

mmsqe commented Dec 23, 2022

Thanks @mmsqe! And sorry for this to have taken this long 🙏

Np, a lot to learn in my side.

mmsqe added a commit to mmsqe/ethermint that referenced this pull request Mar 8, 2023
@mmsqe @fedekunze
@facs95 @GAtom22
tests: make integration test more stable (evmos#1488)
35b3f60 
* wait new blk right before send tx

* larger timeout_commit for priority test

* larger timeout_commit for mempool related test

* mv chain id test to cluster used test

* keep cluster in module scope

* sync gomod2nix

* adjust timeout_commit

* rm prune all in indexer config

* add missing min_gas_multiplier

* wait 1 more blk in upgrade

* only keep 2 validators

* add retry for grpc_eth_call

* wait 1 block before stop

* fix lint

* disable recheck

* bump up upgrade

* sync gomod2nix

* Apply suggestions from code review

* Apply suggestions from code review

* append node log

* fix lint

* expect less gas after ecd7639

* allow retry continue on empty rsp

* update gomod2nix

* fix flake

* mod tidy

* keep grpc only test

* tests(integration): enable recheck tx mode

* update gomod2nix

Co-authored-by: Federico Kunze Küllmer <[email protected]>
Co-authored-by: Freddy Caceres <[email protected]>
Co-authored-by: Tom <[email protected]>
@mmsqe mmsqe mentioned this pull request Mar 8, 2023
Closed
11 tasks
mmsqe added a commit to mmsqe/ethermint that referenced this pull request Mar 8, 2023
@mmsqe @fedekunze
@facs95 @GAtom22
tests: make integration test more stable (evmos#1488)
f562037 
* wait new blk right before send tx

* larger timeout_commit for priority test

* larger timeout_commit for mempool related test

* mv chain id test to cluster used test

* keep cluster in module scope

* sync gomod2nix

* adjust timeout_commit

* rm prune all in indexer config

* add missing min_gas_multiplier

* wait 1 more blk in upgrade

* only keep 2 validators

* add retry for grpc_eth_call

* wait 1 block before stop

* fix lint

* disable recheck

* bump up upgrade

* sync gomod2nix

* Apply suggestions from code review

* Apply suggestions from code review

* append node log

* fix lint

* expect less gas after ecd7639

* allow retry continue on empty rsp

* update gomod2nix

* fix flake

* mod tidy

* keep grpc only test

* tests(integration): enable recheck tx mode

* update gomod2nix

Co-authored-by: Federico Kunze Küllmer <[email protected]>
Co-authored-by: Freddy Caceres <[email protected]>
Co-authored-by: Tom <[email protected]>
@mmsqe mmsqe mentioned this pull request Mar 8, 2023
Merged
11 tasks
mmsqe added a commit to crypto-org-chain/ethermint that referenced this pull request Mar 14, 2023
@mmsqe @yihuang
@fedekunze @facs95 @GAtom22
fix(rpc): chain-id in grpc query is not initialized without abci event (
44a41ad 
#217)

* fix: chain-id in grpc query is not initialized without abci event (evmos#1405)

* fix: chain-id in grpc query is not initialized without abci event

Closes: evmos#1404

Solution:
- pass the chain-id from caller.

* Update CHANGELOG.md

* only override if input is not empty

* add comment to chain id

* pass chain-id to state transition

* Update x/evm/keeper/grpc_query.go

* Apply suggestions from code review

* fix golang lint

* update gomod2nix.toml

* fix unit tests

* update gomod2nix

* api breaking changelog

* add unit tests, and fix TraceBlock by the way

* Update CHANGELOG.md

* test --grpc-only mode in integration tests

* remove tmp var

* Update tests/integration_tests/test_grpc_only.py

* Update x/evm/keeper/grpc_query_test.go

Co-authored-by: mmsqe <[email protected]>

* fix linters

* fix nil pointer in tests

* fix conflicts

* fix conflicts

* fixes

* fix lint

* fix unit test

Co-authored-by: Federico Kunze Küllmer <[email protected]>
Co-authored-by: mmsqe <[email protected]>
Co-authored-by: Freddy Caceres <[email protected]>

* fix test

* tests: make integration test more stable (evmos#1488)

* wait new blk right before send tx

* larger timeout_commit for priority test

* larger timeout_commit for mempool related test

* mv chain id test to cluster used test

* keep cluster in module scope

* sync gomod2nix

* adjust timeout_commit

* rm prune all in indexer config

* add missing min_gas_multiplier

* wait 1 more blk in upgrade

* only keep 2 validators

* add retry for grpc_eth_call

* wait 1 block before stop

* fix lint

* disable recheck

* bump up upgrade

* sync gomod2nix

* Apply suggestions from code review

* Apply suggestions from code review

* append node log

* fix lint

* expect less gas after ecd7639

* allow retry continue on empty rsp

* update gomod2nix

* fix flake

* mod tidy

* keep grpc only test

* tests(integration): enable recheck tx mode

* update gomod2nix

Co-authored-by: Federico Kunze Küllmer <[email protected]>
Co-authored-by: Freddy Caceres <[email protected]>
Co-authored-by: Tom <[email protected]>

* fix lint

---------

Co-authored-by: yihuang <[email protected]>
Co-authored-by: Federico Kunze Küllmer <[email protected]>
Co-authored-by: Freddy Caceres <[email protected]>
Co-authored-by: Tom <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@yihuang yihuang yihuang left review comments

@adisaran64 adisaran64 adisaran64 left review comments

@facs95 facs95 facs95 approved these changes

@fedekunze fedekunze fedekunze approved these changes

@GAtom22 GAtom22 GAtom22 approved these changes

Assignees
No one assigned
Labels
Type: Tests issues and PR related to tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

make integration test more stable
7 participants
@mmsqe @facs95 @yihuang @fedekunze @GAtom22 @adisaran64 @ramacarlucho