Skip to content
This repository has been archived by the owner on Apr 4, 2024. It is now read-only.

test(ante): add test case for gasWanted on ReCheckTx mode #1570

Merged
merged 4 commits into from
Dec 22, 2022
Merged

test(ante): add test case for gasWanted on ReCheckTx mode #1570

merged 4 commits into from
Dec 22, 2022

Conversation

GAtom22
Copy link
Contributor

@GAtom22 GAtom22 commented Dec 22, 2022 •
edited
Loading

Closes: #XXX

Description

Add test for EthGasConsumeDecorator AnteHandler:

  • gasWanted on ReCheckTx mode should be zero

Related to #1566

For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@GAtom22 GAtom22 marked this pull request as ready for review December 22, 2022 14:57
@GAtom22 GAtom22 requested a review from a team as a code owner December 22, 2022 14:57
MalteHerrmann
MalteHerrmann approved these changes Dec 22, 2022
View reviewed changes
Copy link
Contributor

@MalteHerrmann MalteHerrmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested and works!

@fedekunze fedekunze merged commit d3a60a0 into main Dec 22, 2022
@fedekunze fedekunze deleted the GAtom22/fix-recheck-tx branch December 22, 2022 15:07
@fedekunze
Copy link
Contributor

@Mergifyio backport release/v0.20.x

mergify bot pushed a commit that referenced this pull request Dec 22, 2022
@GAtom22 @mergify
test(ante): add test case for gasWanted on ReCheckTx mode (#1570)
d2a3d3a 
* fix(abci): fix reCheckTx gas wanted'

* fix(ante): add changelog entry

* fix(ante): add test case

(cherry picked from commit d3a60a0)
@mergify mergify bot mentioned this pull request Dec 22, 2022
Merged
@mergify
Copy link
Contributor

mergify bot commented Dec 22, 2022

backport release/v0.20.x

✅ Backports have been created

fedekunze pushed a commit that referenced this pull request Dec 22, 2022
@mergify @GAtom22
test(ante): add test case for gasWanted on ReCheckTx mode (#1570) (#…
7c158b1 
…1571)

* fix(abci): fix reCheckTx gas wanted'

* fix(ante): add changelog entry

* fix(ante): add test case

(cherry picked from commit d3a60a0)

Co-authored-by: Tomas Guerra <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@fedekunze fedekunze fedekunze approved these changes

@MalteHerrmann MalteHerrmann MalteHerrmann approved these changes

@Vvaradinov Vvaradinov Awaiting requested review from Vvaradinov

@facs95 facs95 Awaiting requested review from facs95

@danburck danburck Awaiting requested review from danburck

@4rgon4ut 4rgon4ut Awaiting requested review from 4rgon4ut

@adisaran64 adisaran64 Awaiting requested review from adisaran64

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@GAtom22 @fedekunze @MalteHerrmann