Client: Pooled Txs Broadcasting Fixes - #2935
Merged
Merged
Conversation
Codecov Report
Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more. |
Member
|
Actually that’s not only “a failing test” but real misbehavior in our client. 😋 |
Member
|
For completeness for anyone reading this PR: this is relevant and super nice to read https://github.com/ethereum/devp2p/blob/master/caps/eth.md#transaction-exchange |
3 tasks
jochem-brouwer
changed the title
g11tech
reviewed
Aug 5, 2023
jochem-brouwer
force-pushed
the
pooled-txs-fixes
branch
from
August 5, 2023 15:30
5ef8a53 to
156267a
Compare
acolytec3
marked this pull request as ready for review
August 5, 2023 18:49
holgerd77
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses a failing test noted in #2931 where we should be broadcasting the contents of our transaction pool to newly connected peers. Still WIP
This PR is a continuation of #2931, to test hive and other notes: instructions are there.
This also fixes a performance issue in the
sendNewTransactionHashesfunction intxPoolwhere it wasawaitinga devp2p message that never gets a response and was causing some devp2p message handlers to time out silently.