Skip to content

Cancun tests for devnet-8 - #2931

Closed
jochem-brouwer wants to merge 5 commits into
masterfrom
cancun-tests
Closed

Cancun tests for devnet-8#2931
jochem-brouwer wants to merge 5 commits into
masterfrom
cancun-tests

Conversation

@jochem-brouwer

@jochem-brouwer jochem-brouwer commented Aug 1, 2023

Copy link
Copy Markdown
Member

This PR is used to track work on the Cancun tests for devnet-8.

To run;

Git clone https://github.com/marioevz/hive/tree/cancun-dn8-4844-4788

Merge this PR: ethereum/hive#809

Change hive/clients/ethereumjs/ethereumjs.sh: FLAGS="--gethGenesis ./genesis.json --rpc --rpcEngine --saveReceipts --rpcAddr 0.0.0.0 --rpcEngineAddr 0.0.0.0 --rpcEnginePort 8551 --ws false --logLevel debug --rpcDebug --transports rlpx --isSingleNode"

./hive --sim ethereum/engine --client ethereumjs --sim.limit "engine-blobs/"

More output;

./hive --sim ethereum/engine --client ethereumjs --docker.output --loglevel 5

Do not merge since this likely finds bugs in hive.
TODOS

  • Get Client: Pooled Txs Broadcasting Fixes #2935 ready
  • Fix above tests (likely devp2p related regarding eth/68)
  • Open a PR for hive to patch ethereumjs.sh. NOTE: this should allow the websockets to be open. We currently disable the websockets in order to run these tests. (i.e. -- ws false should be replaced by the default --ws)

@jochem-brouwer

jochem-brouwer commented Aug 2, 2023

Copy link
Copy Markdown
Member Author

Currently failing;

Blob Transaction Ordering, Multiple Clients
NewPayloadV3 Before Cancun, 0x00 Data Fields, Empty Array Versioned Hashes
Incorrect BlobGasUsed: Non-Zero on Zero Blobs 
Incorrect BlobGasUsed: GAS_PER_BLOB on Zero Blobs 
Request Blob Pooled Transactions 

Replace blob transactions fixed in 81dbfee

These tests:

Incorrect BlobGasUsed: Non-Zero on Zero Blobs 
Incorrect BlobGasUsed: GAS_PER_BLOB on Zero Blobs 

Fail because hive sends us payloads which have parentBeaconBlockRoot set to null, which cannot be.

NewPayloadV3 Before Cancun, 0x00 Data Fields, Empty Array Versioned Hashes fail is discussed on https://discord.com/channels/595666850260713488/688075293562503241/1136396481864142961

Blob Transaction Ordering, Multiple Clients

This test fails because currently it timeouts. If in simulators/ethereum/engine/globals/globals.go line 100 you change DefaultTestCaseTimeout = time.Second * 60 to something higher, this test passes.

@jochem-brouwer

jochem-brouwer commented Aug 3, 2023

Copy link
Copy Markdown
Member Author

image

These are currently the failing test if the procedure in this PR is followed. These are likely devp2p problems which we should fix. I have updated the OP for things to do for us at hive side as well.

EDIT tests now all pass, with Blob Transaction Ordering, Multiple Clients being very slow needing a higher test time limit than 60s.

To pass: simulators/ethereum/engine/globals/globals.go line 100 change DefaultTestCaseTimeout to 10 minutes.

@jochem-brouwer

Copy link
Copy Markdown
Member Author

Closed in favour of #2935

@holgerd77
holgerd77 deleted the cancun-tests branch August 7, 2023 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant