You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Fix above tests (likely devp2p related regarding eth/68)
Open a PR for hive to patch ethereumjs.sh. NOTE: this should allow the websockets to be open. We currently disable the websockets in order to run these tests. (i.e. -- ws false should be replaced by the default --ws)
Blob Transaction Ordering, Multiple Clients
NewPayloadV3 Before Cancun, 0x00 Data Fields, Empty Array Versioned Hashes
Incorrect BlobGasUsed: Non-Zero on Zero Blobs
Incorrect BlobGasUsed: GAS_PER_BLOB on Zero Blobs
Request Blob Pooled Transactions
This test fails because currently it timeouts. If in simulators/ethereum/engine/globals/globals.go line 100 you change DefaultTestCaseTimeout = time.Second * 60 to something higher, this test passes.
These are currently the failing test if the procedure in this PR is followed. These are likely devp2p problems which we should fix. I have updated the OP for things to do for us at hive side as well.
EDIT tests now all pass, with Blob Transaction Ordering, Multiple Clients being very slow needing a higher test time limit than 60s.
To pass: simulators/ethereum/engine/globals/globals.go line 100 change DefaultTestCaseTimeout to 10 minutes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is used to track work on the Cancun tests for devnet-8.
To run;
Git clone https://github.com/marioevz/hive/tree/cancun-dn8-4844-4788
Merge this PR: ethereum/hive#809
Change
hive/clients/ethereumjs/ethereumjs.sh:FLAGS="--gethGenesis ./genesis.json --rpc --rpcEngine --saveReceipts --rpcAddr 0.0.0.0 --rpcEngineAddr 0.0.0.0 --rpcEnginePort 8551 --ws false --logLevel debug --rpcDebug --transports rlpx --isSingleNode"./hive --sim ethereum/engine --client ethereumjs --sim.limit "engine-blobs/"More output;
./hive --sim ethereum/engine --client ethereumjs --docker.output --loglevel 5Do not merge since this likely finds bugs in hive.
TODOS
eth/68)ethereumjs.sh. NOTE: this should allow the websockets to be open. We currently disable the websockets in order to run these tests. (i.e.-- ws falseshould be replaced by the default--ws)