Skip to content

Engine-api: blobs (4844) fixes - #2841

Closed
jochem-brouwer wants to merge 11 commits into
masterfrom
hive-engine-blobs
Closed

Engine-api: blobs (4844) fixes#2841
jochem-brouwer wants to merge 11 commits into
masterfrom
hive-engine-blobs

Conversation

@jochem-brouwer

@jochem-brouwer jochem-brouwer commented Jun 29, 2023

Copy link
Copy Markdown
Member

Closes #2838

Addresses failing hive tests.

To run: TODO

@jochem-brouwer
jochem-brouwer changed the base branch from master to browser-example-continuation June 29, 2023 15:13
@codecov

codecov Bot commented Jun 29, 2023

Copy link
Copy Markdown

Codecov Report

Merging #2841 (eabfc11) into browser-example-continuation (56f7502) will decrease coverage by 2.78%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

Flag Coverage Δ
block 89.18% <ø> (ø)
blockchain 92.50% <ø> (ø)
client ?
common 97.06% <ø> (ø)
devp2p 86.58% <ø> (ø)
ethash ?
evm 66.99% <ø> (ø)
statemanager 86.41% <ø> (ø)
trie 89.97% <ø> (+0.27%) ⬆️
tx ?
util 86.07% <ø> (ø)
vm 77.13% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Base automatically changed from browser-example-continuation to master June 29, 2023 18:12

@acolytec3 acolytec3 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this PR still valid given #2896?

@jochem-brouwer

Copy link
Copy Markdown
Member Author

I will check, but I think so, since we failed (some) hive tests on devnet7.

@holgerd77

Copy link
Copy Markdown
Member

Can this get an update at some point?

Maybe it’s best to cherry-pick remaining valid changes into a new PR?

@jochem-brouwer

Copy link
Copy Markdown
Member Author

This got merged in #2935

@holgerd77
holgerd77 deleted the hive-engine-blobs branch February 15, 2024 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Hive: engine-blobs tests

3 participants