client: apply engine api changes for devnet 8 - #2896
Merged
Conversation
Codecov Report
Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more. |
g11tech
added
PR state: WIP
package: client
target: master
acolytec3
previously requested changes
Jul 21, 2023
acolytec3
left a comment
acolytec3
left a comment
Contributor
There was a problem hiding this comment.
Looks good! I think one error message needs to be updated but will let you confirm.
Contributor
Author
thank yea updated, gtg for merge now :) |
g11tech
commented
Jul 21, 2023
| const parentBeaconBlockRoot = '0x42942949c4ed512cd85c2cb54ca88591338cbb0564d3a2bea7961a639ef29d64' | ||
|
|
||
| describe(`${method}: call with executionPayloadV1`, () => { | ||
| it('call with invalid block hash without 0x', async () => { |
Contributor
Author
There was a problem hiding this comment.
these tests which are repeat of older versions have been removed
Member
|
Client tests failing, is this this timeout thing? |
Contributor
Author
yea seems like it 🙂 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pending tasks to make client devnet 8 compatible
Could have further changes depending on the acceptance of- ethereum/consensus-specs#3454