Skip to content

ECIP-1061: Move Aztlan to Phoenix block on Mordor; ECIP-1086 Last Call#296

Closed
soc1c wants to merge 2 commits into
masterfrom
s1-aztlan-mordor
Closed

ECIP-1061: Move Aztlan to Phoenix block on Mordor; ECIP-1086 Last Call#296
soc1c wants to merge 2 commits into
masterfrom
s1-aztlan-mordor

Conversation

@soc1c
Copy link
Copy Markdown
Contributor

@soc1c soc1c commented Feb 21, 2020

The rationale is taken from #295

cc @meowsbits

@soc1c soc1c changed the title ECIP-1061: Move Aztlan to Phoenix block on Mordor ECIP-1061: Move Aztlan to Phoenix block on Mordor; ECIP-1086 Last Call Feb 21, 2020
Copy link
Copy Markdown
Member

@meowsbits meowsbits left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be broken into 1 pull request for each ECIP modified (2 pull requests).

EDIT: i can't seem to be able to drop this request-changes review (or to modify it to a comment)... ?

See "It modifies an Accepted ECIP" for my real remaining reason for request-changes review: #296 (review)

@soc1c
Copy link
Copy Markdown
Contributor Author

soc1c commented Feb 21, 2020

@meowsbits no. because the changes proposed are not standalone. this should be accepted as bundle or rejected as bundle. but you wouldn't be able to pick from the two change sets.

Copy link
Copy Markdown
Member

@meowsbits meowsbits left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It modifies an Accepted ECIP... ?

2020-02-21-082833_1051x381_screenshot

@meowsbits
Copy link
Copy Markdown
Member

With my latest understanding of EIP2200 SLOAD gas specification (and related patches), it seems to me that ECIP1086 is invalid/useless, since because EIP2200 does not specify SLOAD gas=800, no patch should be implemented (or now, should actually be reverted in some client cases), and ECIP1086 as a "retrospective allowance" for the EIP2200 gas=200 become a no-op.

@meowsbits
Copy link
Copy Markdown
Member

Would the Mordor revert reuse the same genesis, or a new one to prevent forks?

@meowsbits meowsbits self-requested a review February 21, 2020 13:47
@soc1c
Copy link
Copy Markdown
Contributor Author

soc1c commented Feb 21, 2020

Closing in favor of #297

@soc1c soc1c closed this Feb 21, 2020
@chris-mercer chris-mercer deleted the s1-aztlan-mordor branch May 2, 2025 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants