ECIP-1086: SLOAD Gas Patch for the Testnets#293
Merged
Conversation
soc1c
added
type: std-core
Contributor
Author
Member
|
LGTM |
GregTheGreek
approved these changes
Feb 18, 2020
realcodywburns
approved these changes
Feb 19, 2020
Member
realcodywburns
left a comment
realcodywburns
left a comment
There was a problem hiding this comment.
Lgtm from editor pov. I disagree with the approach on having testnet specific ecips. Testnets are for testing not only what will be deployed but how it will be deployed and should match mainnet implementations exactly
Member
|
SNIP ... text from ETC Discord discussions moved to the Github issue for discussion: |
YazzyYaz
approved these changes
Feb 19, 2020
Contributor
|
LGTM, merging |
This was referenced Feb 21, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues with the Aztlán protocol upgrades were identified and sufficiently patched with the Phoenix protocol upgrades. However, the subsequent activation of these upgrades on the Kotti and Mordor testnets revealed inconsistencies between client implementations. This document proposes a patch for the aforementioned testnets.
Abstract
The EIP-2200 defines structured definitions of net-gas metering for the
SSTOREopcode. This EIP was activated in a bundle called EIP-1679 "Istanbul" on the Ethereum Foundation network and ECIP-1061 "Aztlán" on the Ethereum Classic network.Notably, the difference here is that Istanbul contained EIP-1884 which repriced various opcodes for trie-size dependent operations, whereas Aztlán did not.
Both EIP-1884 and EIP-2200 propose the
SLOAD_GASto be increased from200to800but not all clients correctly implemented this change for both EIPs leaving networks configured with a pick-and-mix EIP configuration such as Aztlán with an incompatible configuration as compared to clients who correctly implemented the specifications.Motivation
This specification seeks to validate the incomplete configuration in favor of retaining the Kotti and Mordor testnets in consensus. This ECIP shall not be considered on mainnet. It's sole purpose is to allow avoiding a rollback on the testnets and having a proper documentation on the cause for the gas mismatch and providing instructions for client developers how to circumvent this.
Discussions to: