simulators/ethereum/pyspec: update for EIP-4844 tests

[spencer-tb]

simulators/ethereum/pyspec

➕ Adds changes required to run EIP-4844 execution-spec-tests:
https://github.com/ethereum/execution-spec-tests/tree/main/tests/eips/eip4844

➕ Now using fixtures-cancun.tar.gz from:
https://github.com/ethereum/execution-spec-tests/releases/tag/v1.0.0

Remaining tasks

• All clients passing on -> https://hivecancun.ethdevops.io/
• Replace RLP decoder with custom function that extracts fields from fixtures for EngineAPI payloads
• Remove go.mod replace in both pyspec and engine simulators (requires Cancun changes to be merged

[fjl]

I wonder, doesn't besu ship with the default trusted setup like all other clients?

[spencer-tb]

Not yet at least - we get thrown this error without including it as a flag:

WARN  | Besu | Failed to start Besu...
[6efa3097] picocli.CommandLine$ParameterException:
 --kzg-trusted-setup is mandatory when providing a custom genesis that support data blobs

I'm assuming it will have the default setup for mainnet so I will dig deeper and ask around!

[Gabriel-Trintinalia]

I believe it ships:

# Copy KZG-trusted-setup
COPY --from=builder /besu/config/src/main/resources/kzg-trusted-setups/mainnet.txt /kzg-trusted-setup.txt

[spencer-tb]

Nice! I'll add this in :D

[jflo]

It ships, but if you specify your own genesis you need to also provide a corresponding setup if that genesis supports datagas.

[fjl]

Why is this replacement needed?

[spencer-tb]

Currently its the only branch (I believe) with the dataGasUsed and excessDataGas fields added the *core.Genesis struct which we are using in types.go

This is the required type here: https://github.com/ethereum/hive/blob/master/simulators/ethereum/engine/client/hive_rpc/hive_rpc.go#L40
that we use to start a clients with a genesis file alongside the EngineAPI

Maybe there is a better way to do this, that allows us to use a custom genesis struct?

Nonetheless once 4844 is merged no replacement will be required!

[fjl]

I see. Please please, if you need certain fields added in go-ethereum, send a PR to go-ethereum! We can get it merged quickly.

When the work on withdrawals was done, I spent quite a bit of time removing module replacements in hive. The replace feature is intended to be used during development but I would really like to avoid committing a replacement to hive unless absolutely necessary.

[fjl]

I'm not a big fan of putting the yaml config files in clients/. Maybe we can create a new directory like inv/4844/ where these will be stored.

I understand that client configs with a custom branch are needed while the clients don't have the feature in their default branch yet. And we definitely need a way to share these configs. So it's OK to put them in the hive repo. But as soon as the feature goes to default, we don't need them anymore. That's why I'm proposing they should be kept in a 4844 specific directory.