Skip to content

Comments

clients/reth: adding reth client definition#717

Merged
fjl merged 23 commits intoethereum:masterfrom
paradigmxyz:master
Aug 22, 2023
Merged

clients/reth: adding reth client definition#717
fjl merged 23 commits intoethereum:masterfrom
paradigmxyz:master

Conversation

@onbjerg
Copy link
Contributor

@onbjerg onbjerg commented Feb 17, 2023

This is a work-in-progress PR to add support for reth.

reth is still early stages, and we will gradually add support for more simulators. Support is being tracked in paradigmxyz/reth#851

Before moving out of draft I will clean up the commit history in this pull request.

@onbjerg onbjerg mentioned this pull request Feb 17, 2023
Closed
@fjl
Copy link
Collaborator

fjl commented Jun 5, 2023 •
edited
Loading

Can we get this merged? It's OK to have clients that do not pass all tests in main branch. Having reth in would make it easier for us to apply ongoing maintenance to the client definition.

For example, we just now renamed the branch build argument to tag. This change also needs to be applied to clients/reth, but we can't do that when it's in a Draft status PR.

gakonst and others added 21 commits August 3, 2023 16:20
@gakonst @onbjerg @Rjected
feat: reth (#1)
14c8ceb 
* wip

* wip

* wip

* feat: add initial block import part of script (#1)

* set up init and import commands

* reorder reth commands

* change command style

* feat: load rest of test chain

* feat: enable rpc

* fix: correct genesis hex mapper

* use apt instead of apk

---------

Co-authored-by: Oliver Nordbjerg <hi@notbjerg.me>
Co-authored-by: Dan Cline <6798349+Rjected@users.noreply.github.com>
@Rjected
revert mapper changes (#2)
30a3419
@Rjected
feat: add shanghai fork timestamp to mapper
9ab46aa
@Rjected
fix: use new reth import UX (#4)
9a2e390
@Rjected
use bootnodes in online steps only (#5)
6fdaaba
@Rjected
uncomment JWT section (#6)
72ec39d 
remove 0x from JWT secret
@Rjected
use patched chain files for rpc-compat (#7)
b2c4bb5 
use fork with correct withdrawals chain
@Rjected
add shanghai timestamp to rpc-compat tests (#8)
578c3b1
@Rjected
add continuous condition for sync test (#9)
4385a1e
@Rjected
fix: add remaining forks to mapper and rpc-compat suite (#10)
0e02303 
* fix: add remaining forks to mapper and rpc-compat suite

* go fmt
@mattsse @Rjected
chore: enable ws (#11)
d97991f
@mattsse @Rjected
chore: disable ascii (#12)
4955f41
@Rjected
feat: ignore error difference when comparing rpc output (#16)
aa7f74f 
* feat: ignore error difference when comparing rpc output

* only ignore rpc error message
@mattsse @Rjected
feat: enable --auto-mine if clique is set (#15)
0b745c5
@mattsse @Rjected
chore: move RUST_LOG_STYLE to top (#19)
79d8197
@Rjected
feat: ignore error codes in error expects (#20)
f29fd09
@Rjected
fix: use proper bash existence check for continuous (#21)
7f7de8d
@Rjected
fix: use proper bash existence check for auto-mine (#22)
362b3e8
@mattsse @Rjected
chore: remove duplicate output (#23)
452485a
@Rjected
use datadir instead of db arg in hive (#24)
152d2da
@mattsse @Rjected
fix: only run --auto-mine when clique requested (#25)
e49ad30
@Rjected
Remove broad error checks and use upstream execution-apis (#27)
e5a04a5 
remove broad error checks and use upstream execution-apis
@Rjected
Copy link
Contributor

Rjected commented Aug 4, 2023

Can we get this merged? It's OK to have clients that do not pass all tests in main branch. Having reth in would make it easier for us to apply ongoing maintenance to the client definition.

Hi @fjl ! Sorry it's been a while, but I'm trying to prepare this so it can be merged. I just changed from branch to tag, to stay up to date, but noticed now that there are .git and .local dockerfiles. After adding those, what else would we need to for this to get merged?

@fjl
Copy link
Collaborator

fjl commented Aug 4, 2023

Alternative Dockerfiles are not mandatory. They are only needed to test the non-default branch of a client. I think the client definition is OK as is.

@fjl
Copy link
Collaborator

fjl commented Aug 4, 2023

The thing about error checks in the rpc-compat suite is on my TODO list, btw!

@Rjected
Copy link
Contributor

Rjected commented Aug 4, 2023

The thing about error checks in the rpc-compat suite is on my TODO list, btw!

awesome! I removed those changes from this PR, since I'd like to just add the client definitions in this PR

@fjl fjl changed the title clients: add reth support clients/reth: adding reth client definition Aug 4, 2023
@fjl fjl marked this pull request as ready for review August 5, 2023 13:32
@fjl fjl merged commit afbaf25 into ethereum:master Aug 22, 2023
github-merge-queue bot pushed a commit to kkrt-labs/hive that referenced this pull request Aug 22, 2023
@bajpai244 @onbjerg
@gakonst @Rjected @mattsse @fjl
dev: sync with latest changes on ethereum/hive (#1)
da860b4 
* clients/reth: adding reth client definition (ethereum#717)


Co-authored-by: Georgios Konstantopoulos <me@gakonst.com>
Co-authored-by: Dan Cline <6798349+Rjected@users.noreply.github.com>
Co-authored-by: Matthias Seitz <matthias.seitz@outlook.de>

* simulators/devp2p: enable discv5 test suite (ethereum#835)

This adds support for running the discv5 test suite from go-ethereum's cmd/devp2p against EL and CL clients.

---------

Co-authored-by: Bjerg <onbjerg@users.noreply.github.com>
Co-authored-by: Georgios Konstantopoulos <me@gakonst.com>
Co-authored-by: Dan Cline <6798349+Rjected@users.noreply.github.com>
Co-authored-by: Matthias Seitz <matthias.seitz@outlook.de>
Co-authored-by: Felix Lange <fjl@twurst.com>
@holiman
Copy link
Contributor

holiman commented Jan 17, 2024

Does paradigmxyz/reth exist? Please see #970

racytech pushed a commit to racytech/hive that referenced this pull request Apr 4, 2025
@barnabasbusa
fix: remove subscribe-all-subnets from default prysm config (ethereum…
6348c0b 
…#717)

Signed-off-by: Barnabas Busa <busa.barnabas@gmail.com>
racytech pushed a commit to racytech/hive that referenced this pull request Apr 4, 2025
@EthPandaOpsBot
chore(main): release 4.2.0 (ethereum#709)
2e9e5a4 
🤖 I have created a release *beep* *boop*
---


##
[4.2.0](ethpandaops/ethereum-package@4.1.0...4.2.0)
(2024-08-19)


### Features

* add customizable configuraiton for prometheus retention
([ethereum#745](ethpandaops/ethereum-package#745))
([6c02dfe](ethpandaops/ethereum-package@6c02dfe))
* add genesis_gaslimit param configuration
([ethereum#726](ethpandaops/ethereum-package#726))
([a4ba9a6](ethpandaops/ethereum-package@a4ba9a6))
* Add Lighthouse PeerDAS Dashboard
([ethereum#736](ethpandaops/ethereum-package#736))
([ffbfde2](ethpandaops/ethereum-package@ffbfde2))
* add peerdas-electra-support
([ethereum#740](ethpandaops/ethereum-package#740))
([663e7e6](ethpandaops/ethereum-package@663e7e6))
* add profiling for prysm
([ethereum#722](ethpandaops/ethereum-package#722))
([7dc6660](ethpandaops/ethereum-package@7dc6660))
* add sanity check
([ethereum#710](ethpandaops/ethereum-package#710))
([b824cac](ethpandaops/ethereum-package@b824cac))
* enable dora pprof
([ethereum#743](ethpandaops/ethereum-package#743))
([2b7be9a](ethpandaops/ethereum-package@2b7be9a))
* generate keys if not default key is used
([ethereum#707](ethpandaops/ethereum-package#707))
([2d1cab5](ethpandaops/ethereum-package@2d1cab5))
* lodestar persists invalid ssz objects by default
([ethereum#730](ethpandaops/ethereum-package#730))
([5a45991](ethpandaops/ethereum-package@5a45991))
* update egg config parameters
([ethereum#737](ethpandaops/ethereum-package#737))
([78c2bc7](ethpandaops/ethereum-package@78c2bc7))


### Bug Fixes

* add debug ns to nethermind
([ethereum#732](ethpandaops/ethereum-package#732))
([372bb52](ethpandaops/ethereum-package@372bb52))
* allow vc properties in participants_matrix.cl
([ethereum#715](ethpandaops/ethereum-package#715))
([c8b9b19](ethpandaops/ethereum-package@c8b9b19))
* besu devnet schedule
([ethereum#734](ethpandaops/ethereum-package#734))
([28b67cd](ethpandaops/ethereum-package@28b67cd))
* blobscan redis dependency
([ethereum#712](ethpandaops/ethereum-package#712))
([0ed1c9c](ethpandaops/ethereum-package@0ed1c9c))
* change churn limit default for pectra tests
([ethereum#747](ethpandaops/ethereum-package#747))
([8109054](ethpandaops/ethereum-package@8109054))
* correctly apply extra params if builder is enabled
([ethereum#725](ethpandaops/ethereum-package#725))
([a94caf0](ethpandaops/ethereum-package@a94caf0))
* disable all assertoor tests by default
([ethereum#738](ethpandaops/ethereum-package#738))
([2961f96](ethpandaops/ethereum-package@2961f96))
* lodestar vc faster startup
([ethereum#721](ethpandaops/ethereum-package#721))
([225e3d8](ethpandaops/ethereum-package@225e3d8))
* readme eof
([ethereum#739](ethpandaops/ethereum-package#739))
([7f94f6e](ethpandaops/ethereum-package@7f94f6e))
* remove custom peerdas images for dora & assertoor
([ethereum#741](ethpandaops/ethereum-package#741))
([a19398d](ethpandaops/ethereum-package@a19398d))
* remove subscribe all subnet nimbus
([ethereum#719](ethpandaops/ethereum-package#719))
([ef92f8f](ethpandaops/ethereum-package@ef92f8f))
* remove subscribe-all-subnets from default prysm config
([ethereum#717](ethpandaops/ethereum-package#717))
([6348c0b](ethpandaops/ethereum-package@6348c0b))
* remove subscribe-all-subnets lighthouse/lodestar/teku
([ethereum#720](ethpandaops/ethereum-package#720))
([cdb20e1](ethpandaops/ethereum-package@cdb20e1))
* update snapshots URL
([ethereum#731](ethpandaops/ethereum-package#731))
([f9269ad](ethpandaops/ethereum-package@f9269ad))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@onbjerg @fjl @Rjected @holiman @gakonst @mattsse