Merged
Conversation
onbjerg
approved these changes
Feb 17, 2023
mattsse
pushed a commit
to mattsse/hive
that referenced
this pull request
Mar 23, 2023
mattsse
pushed a commit
to mattsse/hive
that referenced
this pull request
Mar 24, 2023
mattsse
pushed a commit
that referenced
this pull request
Mar 24, 2023
Rjected
added a commit
that referenced
this pull request
Apr 3, 2023
Rjected
added a commit
that referenced
this pull request
Aug 3, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously we were passing the
gasLimitfield intoinfix_zeros_to_lengthThis resulted in the gas limit having one less zero byte for devp2p tests:
When it should have been:
Instead of fixing the methods, this just removes the additional mappings, because the tests should work without them due to fixes in gakonst/ethers-rs#2145