Skip to content

Comments

fix: only run --auto-mine when clique requested#25

Merged
Rjected merged 1 commit intoparadigmxyz:masterfrom
mattsse:matt/only-enable-automine-for-clique
May 3, 2023
Merged

fix: only run --auto-mine when clique requested#25
Rjected merged 1 commit intoparadigmxyz:masterfrom
mattsse:matt/only-enable-automine-for-clique

Conversation

@mattsse
Copy link
Collaborator

@mattsse mattsse commented May 3, 2023

I believe HIVE_MINER check is wrong

  • HIVE_MINER address to credit with mining rewards

see this for example:

https://hivetests2.ethdevops.io/viewer.html?suiteid=1683065841-921749060b0141a4d882b90889732887.json&suitename=engine-api&testid=19&file=%2Fresults%2Fgo-ethereum%2Fclient-af198dc186a42f67b2701180b98f390c97d600a6052270e65a94111913dc6699.log

Running go-ethereum with flags --pcscdpath="" --verbosity=3 --bootnodes= --networkid 7 --syncmode full --mine --miner.threads 1 --miner.etherbase 658bdf435d810c91414ec09147daa6db62406379 --miner.gasprice 16000000000 --http --http.addr=0.0.0.0 --http.port=8545 --http.api=admin,debug,eth,miner,net,personal,txpool,web3 --ws --ws.addr=0.0.0.0 --ws.origins "*" --ws.api=admin,debug,eth,miner,net,personal,txpool,web3 --authrpc.addr=0.0.0.0 --authrpc.port=8551 --authrpc.jwtsecret /jwtsecret --nat=none

this caused panics in engine API hive tests, but reth entered auto-mine

@mattsse mattsse requested a review from Rjected May 3, 2023 13:36
Copy link
Member

@Rjected Rjected left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Rjected Rjected merged commit 9f9b459 into paradigmxyz:master May 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants