fix(api): return pending block receipts correctly#32457
Closed
calbera wants to merge 1 commit intoethereum:masterfrom
Closed
fix(api): return pending block receipts correctly#32457calbera wants to merge 1 commit intoethereum:masterfrom
calbera wants to merge 1 commit intoethereum:masterfrom
Conversation
calbera
commented
Aug 16, 2025
Comment on lines
+608
to
+610
| if pendingBlock.Hash() != block.Hash() { | ||
| return nil, fmt.Errorf("pending block hash mismatch: %s vs %s", pendingBlock.Hash(), block.Hash()) | ||
| } |
Author
There was a problem hiding this comment.
This feels very dirty as we are forced to make two separate calls to miner.Pending() during execution of GetBlockReceipts.
If open to a larger refactor, one possibility is returning receipts in BlockByNumberOrHash
Author
|
Replaced by #32461 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #32456
Let me know if this approach is wrong or just poorly executed.
Tested on local node running bera-geth.