internal/ethapi, miner: fix GetBlockReceipts for pending#32461
Merged
lightclient merged 4 commits intoethereum:masterfrom Aug 20, 2025
Merged
internal/ethapi, miner: fix GetBlockReceipts for pending#32461lightclient merged 4 commits intoethereum:masterfrom
lightclient merged 4 commits intoethereum:masterfrom
Conversation
rjl493456442
requested review from
MariusVanDerWijden,
fjl,
lightclient and
s1na
as code owners
rjl493456442
force-pushed
the
support-pending-block-receipts
branch
from
622dd04 to
f3758cf
Compare
|
@rjl493456442 thank you for pushing this up. I like this refactor since pending receipts will never come from disk! Closes #32456 |
lightclient
previously approved these changes
Aug 18, 2025
internal/ethapi/api_test.go
Outdated
| chain *core.BlockChain | ||
| accman *accounts.Manager | ||
| acc accounts.Account | ||
| generator func(i int, b *core.BlockGen) |
Member
Author
|
@lightclient I have removed the unused |
lightclient
approved these changes
Aug 20, 2025
gballet
pushed a commit
to gballet/go-ethereum
that referenced
this pull request
Sep 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The alternative fix for #32456
This pull request is opened due to the lacking permission to directly edit the
original PR from berachain. #32457