Skip to content

fix(api): return pending block receipts correctly #32457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
calbera wants to merge 1 commit into from
Closed

fix(api): return pending block receipts correctly #32457

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 12 additions & 3 deletions internal/ethapi/api.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -601,9 +601,18 @@ func (api *BlockChainAPI) GetBlockReceipts(ctx context.Context, blockNrOrHash rp
if block == nil || err != nil {
return nil, err
}
receipts, err := api.b.GetReceipts(ctx, block.Hash())
if err != nil {
return nil, err
var receipts types.Receipts
if blockNr, ok := blockNrOrHash.Number(); ok && blockNr == rpc.PendingBlockNumber {
var pendingBlock *types.Block
pendingBlock, receipts, _ = api.b.Pending()
if pendingBlock.Hash() != block.Hash() {
return nil, fmt.Errorf("pending block hash mismatch: %s vs %s", pendingBlock.Hash(), block.Hash())
}
Comment on lines +608 to +610
Copy link
Copy Markdown
Author

@calbera calbera Aug 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This feels very dirty as we are forced to make two separate calls to miner.Pending() during execution of GetBlockReceipts.

If open to a larger refactor, one possibility is returning receipts in BlockByNumberOrHash

} else {
receipts, err = api.b.GetReceipts(ctx, block.Hash())
if err != nil {
return nil, err
}
}
txs := block.Transactions()
if len(txs) != len(receipts) {
Expand Down
Loading