ethclient/gethclient: RPC client wrapper for geth-specific API#22977
Merged
fjl merged 10 commits intoethereum:masterfrom Jun 30, 2021
Merged
ethclient/gethclient: RPC client wrapper for geth-specific API#22977fjl merged 10 commits intoethereum:masterfrom
fjl merged 10 commits intoethereum:masterfrom
Conversation
This commit adds the package gethclient which is similar to the ethclient and implements some geth specific functionality. Big shoutout to @fxfactorial and @p4u for implementing the functionality in ethclient which I now ported to gethclient.
MariusVanDerWijden
force-pushed
the
gethclient
branch
from
6288c63 to
ecdb7f5
Compare
Contributor
|
The gethclient package should be moved to the ethclient directory, i.e. import path "github.com/ethereum/go-ethereum/ethclient/gethclient". The reason being that we have enough top-level directories already, don't want to add more unless there is a very good reason for it. |
fjl
reviewed
Jun 1, 2021
fjl
changed the title
fjl
reviewed
Jun 1, 2021
fjl
reviewed
Jun 1, 2021
fjl
reviewed
Jun 1, 2021
fjl
reviewed
Jun 1, 2021
fjl
reviewed
Jun 2, 2021
Contributor
|
In general, we should avoid exposing |
This was referenced Jun 9, 2021
Member
Author
Contributor
|
nice job! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the
gethclientpackage which implements geth specific rpc callsHuge shoutout to @fxfactorial and @p4u for their work that I used here.
TODO:
closes #22299
closes #21143