Skip to content

ethclient: added createAccessList#22965

Closed
MariusVanDerWijden wants to merge 3 commits intoethereum:masterfrom
MariusVanDerWijden:ethclient_accesslist
Closed

ethclient: added createAccessList#22965
MariusVanDerWijden wants to merge 3 commits intoethereum:masterfrom
MariusVanDerWijden:ethclient_accesslist

Conversation

@MariusVanDerWijden
Copy link
Copy Markdown
Member

@MariusVanDerWijden MariusVanDerWijden commented May 28, 2021

This PR adds the eth_createAccessList rpc call to the ethclient.

Copy link
Copy Markdown
Contributor

@holiman holiman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread ethclient/ethclient.go

// CreateAccessList tries to create an access list for a specific transaction based on the
// current pending state of the blockchain.
func (ec *Client) CreateAccessList(ctx context.Context, msg ethereum.CallMsg) (*types.AccessList, uint64, string, error) {
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ethclient is designed for all eth-compatible clients. Is it true that eth_createAccessList RPC endpoint is supported by all the (major) clients?

@fjl
Copy link
Copy Markdown
Contributor

fjl commented Jun 1, 2021

We have decided in triage that this is another good candidate for the "ethclient/gethclient" package.

@MariusVanDerWijden
Copy link
Copy Markdown
Member Author

superseeded by #22977

@MariusVanDerWijden MariusVanDerWijden deleted the ethclient_accesslist branch November 30, 2021 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants