Skip to content

ethclient, internal/ethapi: allow eth_call with overrides#23129

Closed
attente wants to merge 1 commit intoethereum:masterfrom
attente:ethclient-call-with-overrides
Closed

ethclient, internal/ethapi: allow eth_call with overrides#23129
attente wants to merge 1 commit intoethereum:masterfrom
attente:ethclient-call-with-overrides

Conversation

@attente
Copy link
Copy Markdown

@attente attente commented Jun 29, 2021

This publishes the previously internal ethapi.StateOverrides type as well as adds the methods CallContractWithOverrides and
PendingCallContractWithOverrides to ethclient.Client.

#22197

This publishes the previously internal ethapi.StateOverrides type as
well as adds the methods CallContractWithOverrides and
PendingCallContractWithOverrides to ethclient.Client.

ethereum#22197
@attente attente force-pushed the ethclient-call-with-overrides branch from 521ed66 to 0be7ed6 Compare June 29, 2021 17:58
@MariusVanDerWijden
Copy link
Copy Markdown
Member

Hey @attente thank you for your contribution.
The overrides are unfortunately geth specific and ethclient should only contain functionality that is standardized between all clients. This is why we decided to put the eth_call with overrides into a new package called gethclient.
The PR for that is here: #22977
Sorry!

@attente
Copy link
Copy Markdown
Author

attente commented Jun 29, 2021

Ah, thank you for the explanation, makes perfect sense.

@attente attente closed this Jun 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants