Rework blockchain import#17973
Merged
karalabe merged 2 commits intoethereum:masterfrom Nov 22, 2018
Merged
Conversation
Contributor
Author
karalabe
reviewed
Nov 12, 2018
karalabe
reviewed
Nov 12, 2018
karalabe
reviewed
Nov 12, 2018
karalabe
reviewed
Nov 12, 2018
karalabe
reviewed
Nov 12, 2018
karalabe
reviewed
Nov 12, 2018
karalabe
reviewed
Nov 12, 2018
karalabe
reviewed
Nov 12, 2018
Member
|
@holiman Could you please rebase this on master? Thx |
Contributor
Author
|
done |
karalabe
reviewed
Nov 19, 2018
karalabe
suggested changes
Nov 19, 2018
Member
karalabe
left a comment
There was a problem hiding this comment.
An initial request set of comments. I still need to look through part of the core in detail, but there's quite a bit of refactoring I requested which modified the code heavily.
Contributor
Author
|
I think I have addressed all concerns now. However, after the latest changes, the code is relatively untested. Once you are satisfied with the general 'look' of the code, we should either add testcases that cover long (bad-state) sidechains, or run some external tests on that scenario. |
karalabe
reviewed
Nov 19, 2018
karalabe
reviewed
Nov 19, 2018
eff5b07 to
0cd152e
Compare
gzliudan
added a commit
to gzliudan/XDPoSChain
that referenced
this pull request
Apr 24, 2025
19 tasks
gzliudan
added a commit
to XinFinOrg/XDPoSChain
that referenced
this pull request
Apr 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

This PR addresses some shortcomings in the blockchain downloader and block processing, specifically the behaviour around (invalid) long sidechains, as happened during the Ropsten constantinople HF.