downloader: different sync strategy#18085
Merged
karalabe merged 2 commits intoethereum:masterfrom Nov 16, 2018
Merged
Conversation
karalabe
suggested changes
Nov 14, 2018
Member
karalabe
left a comment
karalabe
left a comment
There was a problem hiding this comment.
Ah no, a light client test crashes.
karalabe
reviewed
Nov 14, 2018
karalabe
reviewed
Nov 14, 2018
karalabe
reviewed
Nov 14, 2018
karalabe
reviewed
Nov 14, 2018
Contributor
Author
|
Sorry for sloppy tests, fixed! |
karalabe
force-pushed
the
downloader_span
branch
2 times, most recently
from
86b9af0 to
5d91e8c
Compare
karalabe
force-pushed
the
downloader_span
branch
from
5d91e8c to
accc0fa
Compare
Contributor
Author
|
LGTM |
19 tasks
gzliudan
added a commit
to gzliudan/XDPoSChain
that referenced
this pull request
Feb 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains the downloader-specific things from #17973 . However, the change in strategy (to hone in on the remote head, instead of the local head) may not be the best strategy without changing the how blockchain import works.
This PR separates out the strategy into a separate method, with testcases, so it's pretty easy to make changes to it and ensure that a given strategy matches what is expected (it is currently pretty difficult to understand exactly what will happen).