Skip to content

core, eth/downloader: fix validation flaw, fix downloader printout flaw#17974

Merged
karalabe merged 1 commit into
ethereum:masterfrom
holiman:validatorfix
Nov 7, 2018
Merged

core, eth/downloader: fix validation flaw, fix downloader printout flaw#17974
karalabe merged 1 commit into
ethereum:masterfrom
holiman:validatorfix

Conversation

@holiman
Copy link
Copy Markdown
Contributor

@holiman holiman commented Oct 24, 2018

This PR contains only a few minor fixes but without the complete refactoring from #17973 .

@holiman holiman requested a review from karalabe as a code owner October 24, 2018 13:17
@holiman
Copy link
Copy Markdown
Contributor Author

holiman commented Oct 25, 2018

Just a random unrelated failure:

--- FAIL: TestManifestChangeEncrypted (1.28s)
    test_cmd.go:159: Matched stdout text:
        ba7cde98c069a32207a62ff883515a7113e65f143f6289de2f515d4e4d8e5e4e3a7c931eb9a53d4b7456a9b2d8add502947205394dd30921a44674860832c2e9
    --- FAIL: TestManifestChangeEncrypted/add_nested (0.24s)
        test_cmd.go:159: Matched stdout text:
            7c558ef80acf9b92ea55e108263341a2bb2c4a1cd7fdcaab14398165cf239a4e
        test_cmd.go:159: Matched stdout text:
            f2b3613446a293e836e799a23f072de66d2bb6e03711df01cec66f2b7fcd5beaadef4bdf5d509ff81a5d5fa76a02e694358447e6b8420ad9c0cf7257551f55b4
        manifest_test.go:198: unexpected HTTP status: 404 Not Found
FAIL

cc @nonsense

karalabe
karalabe approved these changes Nov 7, 2018
View reviewed changes
Copy link
Copy Markdown
Member

@karalabe karalabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@karalabe karalabe added this to the 1.8.18 milestone Nov 7, 2018
@karalabe karalabe merged commit eea3ae4 into ethereum:master Nov 7, 2018
@gzliudan gzliudan mentioned this pull request Mar 10, 2025
Merged
18 tasks
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Mar 11, 2025
@gzliudan
core, eth/downloader: fix validation and downloader printout flaw (et…
0273448 
…hereum#17974)
gzliudan added a commit to XinFinOrg/XDPoSChain that referenced this pull request Apr 11, 2025
@gzliudan
core, eth/downloader: fix validation and downloader printout flaw (et…
76311b8 
…hereum#17974)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@karalabe karalabe karalabe approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

1.8.18

Development

Successfully merging this pull request may close these issues.

2 participants

@holiman @karalabe