vendor: update fs notification package to build on Go 1.10#15785
Merged
Conversation
fjl
approved these changes
Jan 2, 2018
Member
Author
|
@fjl You did see the first line of the PR description, right?
…On Jan 2, 2018 12:41, "Felix Lange" ***@***.***> wrote:
Merged #15785 <#15785>.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#15785 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAH6GebqAtLaS5Ds7oMqYVUDiDnonWyrks5tGgfvgaJpZM4RPuUH>
.
|
Contributor
|
I didn't see the first line, sorry. You even made it bold. |
Member
Author
|
Np, please be more careful next time.
…On Jan 2, 2018 14:25, "Felix Lange" ***@***.***> wrote:
I did not.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#15785 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAH6GTrAUdban3L_NpwPyK2MQEw6QYp-ks5tGiA3gaJpZM4RPuUH>
.
|
mariameda
pushed a commit
to NiluPlatform/go-nilu
that referenced
this pull request
Aug 23, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upstream code still broken with Go 1.10beta1: rjeczalik/notify#139, don't merge!
Go 1.10 changes a few types around CGO and pointers. This caused the filesystem notification package to fail building on macos:
The issue was known and already fixed upstream in rjeczalik/notify#136, this PR pulls in the latest code.