Skip to content

[WIP, Don't Review] travis, appveyor: upgrade to Go 1.10beta1#15779

Closed
karalabe wants to merge 2 commits into
ethereum:masterfrom
karalabe:go-1.10
Closed

[WIP, Don't Review] travis, appveyor: upgrade to Go 1.10beta1#15779
karalabe wants to merge 2 commits into
ethereum:masterfrom
karalabe:go-1.10

Conversation

@karalabe
Copy link
Copy Markdown
Member

@karalabe karalabe commented Dec 30, 2017

DO NOT MERGE

This is a WIP progress PR mostly to have our code tested against the upcoming Go release. Go 1.10 does a couple more invasive changes which might cause gofmt or the linters to signal new stuff, so it's better to catch in time. Also there's a build error on current master with 32 bit versions of Go, so this PR should help test that for upstream verifications.

Trophies: #15781, #15782, #15783, #15784, #15785, rjeczalik/notify#139.

@karalabe karalabe changed the title travis, appveyor: upgrade to Go 1.10beta1 [WIP, Don't Review] travis, appveyor: upgrade to Go 1.10beta1 Dec 30, 2017
@fjl
Copy link
Copy Markdown
Contributor

fjl commented Jan 8, 2018

go1.10 build seems to work now, closing.

@fjl fjl closed this Jan 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants