Handle pointers that are now integers in Go 1.10 (fixes #135)#136
Merged
Conversation
The Core Services reference types became integer shaped after being pointer shaped in Go 1.9. I moved the thing out into a constant zero or nil variable according to the Go version, in order to avoid duplicating a bunch of code into separate files. This is the required fix according to https://go-review.googlesource.com/c/go/+/66332. This passes tests with Go 1.9.2. and 1.10beta1.
Contributor
Author
|
Windows test failure doesn't look related to this change. |
Contributor
Author
|
I have no idea how to interpret the travis test failure. |
Owner
|
@calmh I'll run the tests manually on a windows box just to confirm. I think I've observed those timeouts previously, did not reproduce them outside the ci environment. |
Contributor
Author
|
Yeah. Changes are build tagged for |
ppknap
approved these changes
Dec 9, 2017
rjeczalik
approved these changes
Dec 9, 2017
Owner
|
Thanks @calmh! We'll need to figure out more graceful timeouts for Windows on AppVeyor, so the tests are less flaky. |
This was referenced Dec 30, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Core Services reference types became integer shaped after being
pointer shaped in Go 1.9. I moved the thing out into a constant zero or
nil variable according to the Go version, in order to avoid duplicating
a bunch of code into separate files.
This is the required fix according to
https://go-review.googlesource.com/c/go/+/66332.
This passes tests with Go 1.9.2. and 1.10beta1.