whisper/whisper2: fix Go 1.10 vet issues on type mismatches#15783
Merged
Conversation
fjl
approved these changes
Jan 2, 2018
tsuzukit
pushed a commit
to tsuzukit/quorum
that referenced
this pull request
May 25, 2018
tsuzukit
added a commit
to tsuzukit/quorum
that referenced
this pull request
May 29, 2018
tsuzukit
added a commit
to tsuzukit/quorum
that referenced
this pull request
May 29, 2018
jpmsam
pushed a commit
to Consensys/quorum
that referenced
this pull request
Jun 4, 2018
* same fix as ethereum/go-ethereum#15783 * Fix insufficient balance for transfer * change chainId of QuorumTestChainConfig
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are two
fmt.Sprintftype errors in whisper, where the requested formatting type is hex%x, but the input is awhisper.Envelope. This PR fixes it by actually printing what the dev intended (the hash on the envelope).Btw, the
fmt.Sprintfis useless in the log (was an automatic refactor), but since whisper2 is deprecated already, this PR is just meant to fix the type issue (which results in a compilation error on Go 1.10), but doesn't attempt to further clean up the old code.