Simplified validate_header func in post-merge forks#1135
Closed
Antrikshgwal wants to merge 9 commits intoethereum:forks/praguefrom
Antrikshgwal:master
Closed
Simplified validate_header func in post-merge forks#1135Antrikshgwal wants to merge 9 commits intoethereum:forks/praguefrom Antrikshgwal:master
Antrikshgwal wants to merge 9 commits intoethereum:forks/praguefrom
Antrikshgwal:master
Conversation
* dev: change type of branch node subnodes * Annotate tuple with 16 * add ellipsis to tuple * explicit tuple * use explicit 16-field tuple * fmt * remove Annotated import * fix types * Use assert_type alongside cast (#1) * Import from typing_extensions instead of typing (#2) --------- Co-authored-by: Sam Wilson <57262657+SamWilsn@users.noreply.github.com>
* dev: update storage trie type * update type in state_db
* dev: stricter type for MessageCallOuput * fix: build doc
- If ``trace`` is passed in the POST, turn on full trace in the T8N tool. - Validate that ``output-basedir`` is also specified as EEST relies on a known location for the trace files. Raise a clarifying error if it is not specified.
Add tracing support for daemon
Contributor
|
Thanks for taking up the issue and for the PR. A couple of points here.
Let me know in case you have any other questions. |
Contributor
|
#1131 has been merged. Could you re-base the PR on the latest |
Contributor
Author
Hey @gurukamath !! |
Contributor
Yes. I see there are conflicts with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to Issue #1133
How was it fixed?
Simplified the validate_header function in Cancun, shanghai and Paris forks in the forks.py file since they are the post-merge forks.
Added documentation in the function docstring clarifying that for post-merge forks, the parent header is always the last header in the chain.
Cute Animal Picture