Refactor Environment#1131
Merged
gurukamath merged 25 commits intoethereum:forks/praguefrom Mar 5, 2025
Merged
Conversation
There are parallels between how the regular block gas is handled and how the blob gas is handled. This commit refactors blob gas canculation to bring them in line with block gas
Create the BlockEnvironment and TransactionEnvironment dataclasses BlockEnvironment holds data that is chain or block scoped TransactionEnvironment holds data that is transaction scoped Message holds data that is specific to a message call
gurukamath
requested review from
SamWilsn and
petertdavies
and removed request for
SamWilsn
petertdavies
requested changes
Feb 25, 2025
Contributor
petertdavies
left a comment
petertdavies
left a comment
There was a problem hiding this comment.
This is really good! I think you missed some cleanup in your test refactoring, but otherwise I am happy to approve.
The tests from execution_spec_tests should now be a part of EEST
SamWilsn
reviewed
Feb 26, 2025
Contributor
SamWilsn
left a comment
SamWilsn
left a comment
There was a problem hiding this comment.
Part one of two hundred and three.
SamWilsn
reviewed
Feb 27, 2025
| Items containing contract creation or message call specific data. | ||
| """ | ||
| accessed_addresses = set() | ||
| accessed_addresses.add(caller) |
Contributor
There was a problem hiding this comment.
Wow, the old code here was pretty misleading.
| gas: Uint | ||
| access_list_addresses: Set[Address] | ||
| access_list_storage_keys: Set[Tuple[Address, Bytes32]] | ||
| tx_index: Uint |
Contributor
There was a problem hiding this comment.
Would this be more descriptive (and still accurate)?
Suggested change
| tx_index: Uint | |
| index_in_block: Uint |
Contributor
Author
There was a problem hiding this comment.
Not sure how index_in_block fits in with system transactions processing since there isn't an actual transaction in the block.
Contributor
There was a problem hiding this comment.
Ah, interesting. So system transactions have an index, but do not appear in the list of txs in the block?
Contributor
Author
There was a problem hiding this comment.
Actually on second thought, we should set the index to None for the system transactions and rename to index_in_block for actual transactions. This is only used in the context of tracing where the index and hash is used as an identifier for the generated trace. I will update this name.
SamWilsn
approved these changes
Mar 3, 2025
petertdavies
approved these changes
Mar 3, 2025
This was referenced Mar 5, 2025
fselmo
pushed a commit
to fselmo/execution-specs
that referenced
this pull request
Apr 9, 2025
* refactor blob gas logic There are parallels between how the regular block gas is handled and how the blob gas is handled. This commit refactors blob gas canculation to bring them in line with block gas * create BlockEnvironment and TransactionEnvironment Create the BlockEnvironment and TransactionEnvironment dataclasses BlockEnvironment holds data that is chain or block scoped TransactionEnvironment holds data that is transaction scoped Message holds data that is specific to a message call * refactor validate_header * update t8n * update evm tracing * backport changes to cancun * port to shanghai * port changes to paris * port to london * port berlin * port istanbul * port constantinople * port byzantium * port spurious_dragon * port older forks * fix t8n receipts * update testing * process_withdrawals update * fixes for doc * remove execution_spec_tests entry The tests from execution_spec_tests should now be a part of EEST * use default_factory in BlockOutput * minor fixes 1 * define current_block_number in block_hash opcode * rename tx_index to index_in_block * fix vm test runs
SamWilsn
pushed a commit
to SamWilsn/eth1.0-specs
that referenced
this pull request
Apr 11, 2025
* refactor blob gas logic There are parallels between how the regular block gas is handled and how the blob gas is handled. This commit refactors blob gas canculation to bring them in line with block gas * create BlockEnvironment and TransactionEnvironment Create the BlockEnvironment and TransactionEnvironment dataclasses BlockEnvironment holds data that is chain or block scoped TransactionEnvironment holds data that is transaction scoped Message holds data that is specific to a message call * refactor validate_header * update t8n * update evm tracing * backport changes to cancun * port to shanghai * port changes to paris * port to london * port berlin * port istanbul * port constantinople * port byzantium * port spurious_dragon * port older forks * fix t8n receipts * update testing * process_withdrawals update * fixes for doc * remove execution_spec_tests entry The tests from execution_spec_tests should now be a part of EEST * use default_factory in BlockOutput * minor fixes 1 * define current_block_number in block_hash opcode * rename tx_index to index_in_block * fix vm test runs
SamWilsn
pushed a commit
that referenced
this pull request
May 15, 2025
* refactor blob gas logic There are parallels between how the regular block gas is handled and how the blob gas is handled. This commit refactors blob gas canculation to bring them in line with block gas * create BlockEnvironment and TransactionEnvironment Create the BlockEnvironment and TransactionEnvironment dataclasses BlockEnvironment holds data that is chain or block scoped TransactionEnvironment holds data that is transaction scoped Message holds data that is specific to a message call * refactor validate_header * update t8n * update evm tracing * backport changes to cancun * port to shanghai * port changes to paris * port to london * port berlin * port istanbul * port constantinople * port byzantium * port spurious_dragon * port older forks * fix t8n receipts * update testing * process_withdrawals update * fixes for doc * remove execution_spec_tests entry The tests from execution_spec_tests should now be a part of EEST * use default_factory in BlockOutput * minor fixes 1 * define current_block_number in block_hash opcode * rename tx_index to index_in_block * fix vm test runs
danceratopz
pushed a commit
to danceratopz/execution-specs
that referenced
this pull request
Oct 22, 2025
* export chain_id in fixtureConfig * adjust unit tests * Update src/pytest_plugins/consume/hive_simulators/conftest.py * fix * fix: Make fixture readers backwards compatible --------- Co-authored-by: Mario Vega <marioevz@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(closes #1130 )
(closes #1115 )
(closes #799)
(closes #993 )
What was wrong?
The Environment data class has some transaction scope attributes like sender, origin and a few others. Ideally, this data class should only have block scope attributes and the transaction scope attributes should be moved to a different data class.
This refactor has a few really nice benefits including
Clear and logical separation between the scopes
Simplifying the signature of a lot of functions including the apply_body function (We can now pass just a single
block_envparameter instead of a large number of individual attributes that might change with hard forks)Simplification of the code in t8n
Simplification of system transaction processing code
How was it fixed?
BlockEnvironment,TransactionEnvironmentandBlockOutputdataclassesEESTtest fixtures as well asethereum/testsfixtures