Skip to content

Comments

Add tracing support for daemon#1109

Merged
petertdavies merged 1 commit intoethereum:masterfrom
fselmo:spec-resolver-tracing
Feb 13, 2025
Merged

Add tracing support for daemon#1109
petertdavies merged 1 commit intoethereum:masterfrom
fselmo:spec-resolver-tracing

Conversation

@fselmo
Copy link
Contributor

@fselmo fselmo commented Feb 4, 2025

What was wrong?

Related to ethereum/execution-spec-tests#1174

Tracing is not currently working via daemon when --traces is passed via EEST when filling tests.

How was it fixed?

  • If trace is passed in the POST, turn on full trace in the T8N tool.
  • Validate that output-basedir is also specified as EEST relies on a known location for the trace files. Raise a clarifying
    error if it is not specified.

Cute Animal Picture

Screenshot 2025-02-04 at 08 43 22

@fselmo fselmo mentioned this pull request Feb 4, 2025
Merged
4 tasks
@fselmo fselmo marked this pull request as ready for review February 4, 2025 15:44
@fselmo
Copy link
Contributor Author

fselmo commented Feb 4, 2025 •
edited
Loading

Ah, it looks like there's an ethereum.rlp issue with EEST if merging into master here. Which branch does EEST expect / which should I PR against?

edit: I added a comment on the related EEST PR as well. Might be worth PRing the EEST changes to the branch with ethereum.rlp support.

@fselmo fselmo marked this pull request as draft February 4, 2025 15:48
@fselmo fselmo force-pushed the spec-resolver-tracing branch from 404435b to 3f8ad1c Compare February 4, 2025 15:52
@fselmo fselmo marked this pull request as ready for review February 4, 2025 17:24
@fselmo fselmo changed the title Add tracing support for daemon: Add tracing support for daemon Feb 4, 2025
@fselmo fselmo force-pushed the spec-resolver-tracing branch 2 times, most recently from 846a8be to 4ab6a46 Compare February 5, 2025 04:53
@danceratopz
Copy link
Member

danceratopz commented Feb 5, 2025

Ah, it looks like there's an ethereum.rlp issue with EEST if merging into master here. Which branch does EEST expect / which should I PR against?

edit: I added a comment on the related EEST PR as well. Might be worth PRing the EEST changes to the branch with ethereum.rlp support.

This problem is on EEST's side, we'll take care of it there. More background here: ethereum/execution-spec-tests#1174 (comment)

marioevz
marioevz reviewed Feb 5, 2025
View reviewed changes
Copy link
Member

@marioevz marioevz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a tiny comment, but overall works great for EEST.

marioevz
marioevz reviewed Feb 5, 2025
View reviewed changes
@fselmo
Add tracing support for daemon:
7f0e751 
- If ``trace`` is passed in the POST, turn on full trace in the T8N tool.

- Validate that ``output-basedir`` is also specified as EEST relies on a
  known location for the trace files. Raise a clarifying error if it is not
  specified.
@fselmo fselmo force-pushed the spec-resolver-tracing branch from 4ab6a46 to 7f0e751 Compare February 5, 2025 17:39
@petertdavies petertdavies merged commit 78fb726 into ethereum:master Feb 13, 2025
5 checks passed
danceratopz pushed a commit to danceratopz/execution-specs that referenced this pull request Oct 22, 2025
@shemnon
Merge pull request ethereum#1109 from shemnon/eof/create-data-overwrite
8288c0b 
feat(tests): EOF - EIP-7620: verify RETURNCONTRACT does not overwrite containing contract
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@marioevz marioevz marioevz left review comments

@petertdavies petertdavies petertdavies approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@fselmo @danceratopz @petertdavies @marioevz