Skip to content

refactor(fw): use ethereum-rlp instead of ethereum.rlp#1180

Merged
marioevz merged 4 commits intomainfrom
chore/tooling/ethereum-rlp
Feb 5, 2025
Merged

refactor(fw): use ethereum-rlp instead of ethereum.rlp#1180
marioevz merged 4 commits intomainfrom
chore/tooling/ethereum-rlp

Conversation

@danceratopz
Copy link
Member

🗒️ Description

Updates EEST framework libraries to use Sam's new ethereum-rlp library, which was moved out of the ethereum package in:

🔗 Related Issues

ethereum-rlp was already added as a dependency as a hot-fix to CI issues in:

✅ Checklist

  • All: Set appropriate labels for the changes.
  • All: Considered squashing commits to improve commit history.
  • All: Added an entry to CHANGELOG.md.

@danceratopz danceratopz added type:refactor Type: Refactor scope:fw Scope: Framework (evm|tools|forks|pytest) scope:deps Scope: Updates package dependencies labels Feb 5, 2025
@danceratopz danceratopz requested a review from marioevz February 5, 2025 14:01
@danceratopz
Copy link
Member Author

I did a quick sanity check of test fixtures using a subset of tests locally via hasher to ensure there were no changes. I used:

  • tests/cancun/eip4844_blobs/ as they do rlp modification,
  • tests/shanghai/eip4895_withdrawals/ as the withdrawals lists get RLP encoded.

Copy link
Member

@marioevz marioevz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@marioevz marioevz merged commit 902f2a8 into main Feb 5, 2025
21 checks passed
@marioevz marioevz deleted the chore/tooling/ethereum-rlp branch February 5, 2025 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

scope:deps Scope: Updates package dependencies scope:fw Scope: Framework (evm|tools|forks|pytest) type:refactor Type: Refactor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants