Skip to content

chore(all): add ethereum-rlp as a dependency#1080

Merged
danceratopz merged 1 commit intomainfrom
add-ethereum-rlp
Jan 16, 2025
Merged

chore(all): add ethereum-rlp as a dependency#1080
danceratopz merged 1 commit intomainfrom
add-ethereum-rlp

Conversation

@danceratopz
Copy link
Member

@danceratopz danceratopz commented Jan 15, 2025

🗒️ Description

Add https://pypi.org/project/ethereum-rlp/ as a dependency to address the recent fails in CI, cf #1083.

This also required bumping the version of uv used in CI to 0.5.20 to fix #1084.

🔗 Related Issues

Fixes #1083.

✅ Checklist

  • All: Set appropriate labels for the changes.
  • All: Considered squashing commits to improve commit history.
  • All: Added an entry to CHANGELOG.md. skipped

@danceratopz danceratopz added the type:chore Type: Chore label Jan 16, 2025
@danceratopz danceratopz self-assigned this Jan 16, 2025
@danceratopz danceratopz marked this pull request as ready for review January 16, 2025 09:22
@danceratopz danceratopz changed the title chore(deps): add dependency on ethereum-rlp chore(all): add ethereum-rlp as a dependency Jan 16, 2025
@danceratopz danceratopz requested a review from winsvega January 16, 2025 09:30
Copy link

@winsvega winsvega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would that resolve the issue with rlp import on my json schema verification pr?

@danceratopz
Copy link
Member Author

would that resolve the issue with rlp import on my json schema verification pr?

yup

@danceratopz danceratopz merged commit 06abe36 into main Jan 16, 2025
21 checks passed
@danceratopz danceratopz deleted the add-ethereum-rlp branch January 16, 2025 09:50
fselmo pushed a commit to fselmo/execution-spec-tests that referenced this pull request Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type:chore Type: Chore

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug(tooling): running uv or tox fails with Failed to parse uv.lock bug(ci): fill fails - eels resolver complains about missing dependency

2 participants