Merged
Conversation
SamWilsn
force-pushed
the
ethereum-rlp
branch
2 times, most recently
from
d9255a4 to
534ee74
Compare
SamWilsn
force-pushed
the
ethereum-rlp
branch
from
534ee74 to
0ffff6c
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1034 +/- ##
==========================================
- Coverage 83.59% 83.56% -0.04%
==========================================
Files 644 649 +5
Lines 36123 35976 -147
==========================================
- Hits 30198 30063 -135
+ Misses 5925 5913 -12
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
gurukamath
reviewed
Jan 15, 2025
| # only `pytest.raises` the correct exception type instead of | ||
| # all of them. | ||
| with pytest.raises(EthereumException): | ||
| with pytest.raises((EthereumException, RLPException)): |
Contributor
There was a problem hiding this comment.
Might be worth it to investigate in a separate issue/PR if we can separate out these two exception and also see if we can start using InvalidBlock instead of EthereumException
Contributor
Author
There was a problem hiding this comment.
This used to be InvalidBlock, but after the changes I've done for #1021, not everything is a subclass.
gurukamath
approved these changes
Jan 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was wrong?
Circular dependency between tests and EELS.
How was it fixed?
Splitting out the RLP code into its own library.
Cute Animal Picture