Conversation
marioevz
force-pushed
the
update-2537-vectors
branch
from
debf661 to
20780f2
Compare
marioevz
commented
Jan 15, 2025
jochem-brouwer
approved these changes
Jan 15, 2025
Member
jochem-brouwer
left a comment
jochem-brouwer
left a comment
There was a problem hiding this comment.
Will approve, LGTM, assuming that the JSONs are copied from ethereum/EIPs#9217 👍 😄
danceratopz
added
type:bug
danceratopz
approved these changes
Jan 15, 2025
Member
danceratopz
left a comment
danceratopz
left a comment
There was a problem hiding this comment.
Amazing, nice work @marioevz and @jochem-brouwer. The new cross-check is a really nice addition.
I spotted and cleaned up a couple of leftovers from the ruff migration #1058.
Ruff does not apply E501 to lines that consist of a single "word"
danceratopz
force-pushed
the
update-2537-vectors
branch
from
adf8f06 to
3b40748
Compare
Member
|
Rebased on main to get this fix for CI: |
16 tasks
fselmo
pushed a commit
to fselmo/execution-spec-tests
that referenced
this pull request
Jan 24, 2025
* fix(tests): EIP-2537 update vectors * fix(tests): EIP-2537: vector update 2 * feat(tests): EIP-2537: add cross-check to verify JSON gas values * Update tests/prague/eip2537_bls_12_381_precompiles/conftest.py * docs(tests): add source of 2537 JSON test vectors * style(tests): remove superflous line-too-long (E501) pragmas Ruff does not apply E501 to lines that consist of a single "word" * style(tests): clean-up git merge artifact from docstring --------- Co-authored-by: danceratopz <danceratopz@gmail.com>
kclowes
pushed a commit
to kclowes/execution-spec-tests
that referenced
this pull request
Oct 20, 2025
* fix(tests): EIP-2537 update vectors * fix(tests): EIP-2537: vector update 2 * feat(tests): EIP-2537: add cross-check to verify JSON gas values * Update tests/prague/eip2537_bls_12_381_precompiles/conftest.py * docs(tests): add source of 2537 JSON test vectors * style(tests): remove superflous line-too-long (E501) pragmas Ruff does not apply E501 to lines that consist of a single "word" * style(tests): clean-up git merge artifact from docstring --------- Co-authored-by: danceratopz <danceratopz@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🗒️ Description
MUL precompile JSON files are not deleted as these are now used by calling the MSM precompile instead.
The generated fixtures are identical.
@jochem-brouwer
🔗 Related Issues
None
✅ Checklist
mkdocs servelocally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.