Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update breakpoints #883

Merged
merged 4 commits into from
Mar 27, 2020
Merged

Conversation

carlfairclough
Copy link
Contributor

@carlfairclough carlfairclough commented Mar 26, 2020

Updated all breakpoints and relevant classes.

Description

  • 320px or greater $breakXS, .s-up-* This should only be necessary in exceptional circumstances
  • 440px or greater $breakS, .s-up-* Infrequently used but may be necessary
  • 768px or greater $breakM, .m-up-* A very frequently used breakpoint
  • 1024px or greater $breakL, .l-up-* A very frequently used breakpoint
  • 1440px or greater $breakXL, .l-up-* Used as the max width, seldom a breakpoint

Related Issue

Resolves #762 & Resolves #864

Copy link
Member

@samajammin samajammin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Nice work.

@samajammin samajammin merged commit 8d2bd4b into ethereum:dev Mar 27, 2020
@samajammin samajammin mentioned this pull request Mar 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

XL screen layout regression Refactor screen breakpoints
2 participants