Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XL screen layout regression #864

Closed
samajammin opened this issue Mar 21, 2020 · 2 comments · Fixed by #883
Closed

XL screen layout regression #864

samajammin opened this issue Mar 21, 2020 · 2 comments · Fixed by #883
Labels
bug 🐛 Something isn't working

Comments

@samajammin
Copy link
Member

Describe the bug

We've had a regression of #207. Currently the site navigation stretches the width of the screen, regardless of width.

To Reproduce
Steps to reproduce the behavior:

  1. Visit ethereum.org using an XL screen (i.e. width greater than 1440px)

Expected behavior

See #207 for context - site content (including the nav & footer) should not exceed a width of $contentWidthXL (1440px), no matter how wide the user's screen is. We should have a container that restricts this width.

Screenshots

Image 2020-03-21 at 2 48 26 PM

@samajammin samajammin added the bug 🐛 Something isn't working label Mar 21, 2020
@carlfairclough
Copy link
Contributor

Huh. The offset there is surprising.

The footer is currently using the updated breakpoints, which are fluid with no currently defined max-width (see: https://www.figma.com/file/rQK2dt9eaLOMmvTOf5ifdr/Ethereum.org-Style-Guide-RC1?node-id=3%3A0).

The offset here, however, is wrong. I believe this fix should be part of #762

@samajammin
Copy link
Member Author

Sounds good to me @carlfairclough. You game with setting a max width container? I don't know if that was ever discussed in the style guide.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants