Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor screen breakpoints #762

Closed
3 tasks
samajammin opened this issue Feb 19, 2020 · 0 comments · Fixed by #883
Closed
3 tasks

Refactor screen breakpoints #762

samajammin opened this issue Feb 19, 2020 · 0 comments · Fixed by #883
Assignees
@samajammin
Labels
design required 🎨 This involves design changes feature ✨ This is enhancing something existing or creating something new

Comments

@samajammin
Copy link
Member

samajammin commented Feb 19, 2020 •
edited
Loading

Describe the solution you'd like

See the Figma file style guide for implementation details.

  • Breakpoint variables (config.styl)
  • Update all media queries to rely on these breakpoints
  • Replace $MQMobile references (those styles are likely broken)

Additional context

Part #753, the output of #668 (see Figma file)
@samajammin samajammin added feature ✨ This is enhancing something existing or creating something new design required 🎨 This involves design changes labels Feb 19, 2020
@samajammin samajammin self-assigned this Feb 19, 2020
@samajammin samajammin mentioned this issue Feb 19, 2020
Closed
34 tasks
@carlfairclough carlfairclough mentioned this issue Feb 27, 2020
Merged
This was referenced Mar 21, 2020
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@samajammin samajammin

Labels
design required 🎨 This involves design changes feature ✨ This is enhancing something existing or creating something new
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update breakpoints carlfairclough/ethereum-org-website
1 participant
@samajammin