Explicitly validate public key when processing Deposit#2987
Closed
Nashatyrev wants to merge 4 commits intoethereum:devfrom
Closed
Explicitly validate public key when processing Deposit#2987Nashatyrev wants to merge 4 commits intoethereum:devfrom
Nashatyrev wants to merge 4 commits intoethereum:devfrom
Conversation
dapplion
approved these changes
Sep 9, 2022
Member
dapplion
left a comment
dapplion
left a comment
There was a problem hiding this comment.
Being explicit about this detail makes sense to me 👍
2 tasks
Contributor
|
It looks fine to me, but I hope to get more reviews 👀 before we modify the phase0 spec. |
Member
|
I am closing this issue because it seems stale. Please, do not hesitate to reopen it if this is a mistake |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deposits are the only source of non-validated public keys, so suggesting to add explicit public key validation statement to
process_depositfunction.bls.Verifyfunction (and its batch variants) is a bit ambiguous in the case ifBLSPubkeyis not valid (either invalid serialization or outside of the curve or outside of the group): whether it should returnfalseor throw an error.In all other cases (besides
process_deposit)bls.Verifycan't receive an invalidBLSPubkeysince all of them come from the state and are inherently valid. Reasoning that way it could make sense to throw error if invalid pubkey is passed tobls.Verifysince it would mean kind of fatal implementation error. In that case suggested implicit public key validation makes sense.