Skip to content

Explicitly validate public key when processing Deposit #2987

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Nashatyrev wants to merge 4 commits into from
Closed

Explicitly validate public key when processing Deposit #2987

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
77f6493
Explicitly validate public key when processing Deposit
Nashatyrev Sep 8, 2022
618dd30
Add KeyValidate to bls.py
Nashatyrev Sep 8, 2022
7ea688c
Fix py formatting
Nashatyrev Sep 9, 2022
51ba721
Fallback to py_ecc as milagro_bls_binding has no KeyValidate binding
Nashatyrev Sep 9, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions specs/phase0/beacon-chain.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1868,6 +1868,10 @@ def process_deposit(state: BeaconState, deposit: Deposit) -> None:
amount = deposit.data.amount
validator_pubkeys = [v.pubkey for v in state.validators]
if pubkey not in validator_pubkeys:
# Validate the public key which is not checked by the deposit contract
if not bls.KeyValidate(pubkey):
return

# Verify the deposit signature (proof of possession) which is not checked by the deposit contract
deposit_message = DepositMessage(
pubkey=deposit.data.pubkey,
Expand Down
11 changes: 11 additions & 0 deletions tests/core/pyspec/eth2spec/utils/bls.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,6 +107,17 @@ def Sign(SK, message):
return bls.Sign(SK.to_bytes(32, 'big'), message)


@only_with_bls(alt_return=True)
def KeyValidate(pubkey):
try:
# Fallback to py_ecc as milagro_bls_binding has no KeyValidate binding
result = py_ecc_bls.KeyValidate(pubkey)
except Exception:
result = False
finally:
return result


@only_with_bls(alt_return=STUB_COORDINATES)
def signature_to_G2(signature):
return _signature_to_G2(signature)
Expand Down