Skip to content

Add test_process_deposit::test_key_validate_invalid #2989

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
djrtwo merged 2 commits into from
Sep 13, 2022
Merged

Add test_process_deposit::test_key_validate_invalid #2989

djrtwo merged 2 commits into from
Sep 13, 2022

Conversation

@hwwhww
Copy link
Contributor

@hwwhww hwwhww commented Sep 12, 2022

Add the test case to address issue #2986 and PR #2987.

@hwwhww hwwhww added the testing CI, actions, tests, testing infra label Sep 12, 2022
@hwwhww
Copy link
Contributor Author

hwwhww commented Sep 12, 2022

To ensure KeyValidate also checks G1 decompression rules, I added one case from G1 decompression: https://github.com/ethereum/bls12-381-tests/blob/5d36085a1e6b32a4c548982e1f3013533a26e27a/main.py#L588

Note that client teams should run and pass ALL decompression tests from https://github.com/ethereum/bls12-381-tests

@djrtwo djrtwo merged commit 770a603 into dev Sep 13, 2022
@djrtwo djrtwo deleted the deposit-zero-pk branch September 13, 2022 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@djrtwo djrtwo djrtwo approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

testing CI, actions, tests, testing infra

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@hwwhww @djrtwo