Skip to content

Pluralize gloas execution payload endpoint paths - #613

Merged
nflaig merged 2 commits into
masterfrom
pluralize
Jun 1, 2026
Merged

Pluralize gloas execution payload endpoint paths#613
nflaig merged 2 commits into
masterfrom
pluralize

Conversation

@nflaig

@nflaig nflaig commented May 28, 2026

Copy link
Copy Markdown
Member

Align the new gloas routes with the REST naming convention used elsewhere in the spec (blocks, states, etc.), where a resource addressed by an id or published to a collection uses a plural noun.

@nflaig nflaig added the Gloas api's needed in Gloas fork. label May 28, 2026

@rolfyone rolfyone left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nflaig
nflaig merged commit 2075db0 into master Jun 1, 2026
3 checks passed
@nflaig
nflaig deleted the pluralize branch June 1, 2026 20:33
nflaig added a commit to ChainSafe/lodestar that referenced this pull request Jun 1, 2026
shane-moore added a commit to shane-moore/beacon-APIs that referenced this pull request Jun 1, 2026
…with-payload

Resolve execution_payload path conflicts from ethereum#613 (pluralized endpoint paths): take master's plural forms for the already-merged ethereum#552 endpoints (execution_payload_bids, execution_payload_envelopes/{block_id}). The two new ethereum#580 envelope endpoints (POST execution_payload_envelope and validator GET execution_payload_envelope) are kept as-is here and pluralized in the follow-up commit.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
shane-moore added a commit to shane-moore/beacon-APIs that referenced this pull request Jun 1, 2026
Rename the two new envelope paths added by this PR to plural, matching the beacon-APIs collection convention (blocks, blinded_blocks, blobs) and ethereum#613, per nflaig review (r3337188903):
- POST /eth/v1/beacon/execution_payload_envelopes
- GET /eth/v1/validator/execution_payload_envelopes/{slot}/{beacon_block_root}

$ref filenames are left unchanged; only the URL path keys, the CHANGES.md entries, and the block.v4 cross-reference change. The execution_payload_bid event name stays singular.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
mergify Bot pushed a commit to sigp/lighthouse that referenced this pull request Jun 5, 2026
tldr the routes got pluralized
ethereum/beacon-APIs#613


  


Co-Authored-By: Eitan Seri-Levi <eserilev@ucsc.edu>
pull Bot pushed a commit to All-Blockchains/prysm that referenced this pull request Jun 10, 2026
**What type of PR is this?**

 Bug fix


**What does this PR do? Why is it needed?**

- support for ssz on get and propose payload envelope and payload
envelope content
- query parameter for gossip validation on payload envelope

relies on OffchainLabs#16421 and
OffchainLabs#16306, needs some small
changes to hook ptc up, if ptc is no issue 16421 is mainly required

Testing
```
participants:
  - el_type: ethrex
    el_image: ethpandaops/ethrex:glamsterdam-devnet-4
    el_extra_params:
      - --http.api=eth,net,web3,admin
    cl_type: prysm
    cl_image: gcr.io/offchainlabs/prysm/beacon-chain:latest
    vc_image: gcr.io/offchainlabs/prysm/validator:latest
    supernode: true
    count: 2
    cl_extra_params:
      - --subscribe-all-subnets
      - --verbosity=debug
    vc_extra_params:
      - --enable-beacon-rest-api
      - --stateless
      - --verbosity=debug

  - el_type: ethrex
    el_image: ethpandaops/ethrex:glamsterdam-devnet-4
    el_extra_params:
      - --http.api=eth,net,web3,admin
    cl_type: prysm
    cl_image: gcr.io/offchainlabs/prysm/beacon-chain:latest
    vc_image: gcr.io/offchainlabs/prysm/validator:latest
    validator_count: 63
    cl_extra_params:
      - --verbosity=debug
    vc_extra_params:
      - --enable-beacon-rest-api
      - --verbosity=debug

network_params:
  fulu_fork_epoch: 0
  gloas_fork_epoch: 2
  seconds_per_slot: 6
  genesis_delay: 40

additional_services:
  - dora

global_log_level: debug

```

**Which issues(s) does this PR fix?**

partially fixes ethereum/beacon-APIs#580 depends
on shane-moore/beacon-APIs#10
implements ethereum/beacon-APIs#613

**Other notes for review**

**Acknowledgements**

- [x] I have read
[CONTRIBUTING.md](https://github.com/prysmaticlabs/prysm/blob/develop/CONTRIBUTING.md).
- [x] I have included a uniquely named [changelog fragment
file](https://github.com/prysmaticlabs/prysm/blob/develop/CONTRIBUTING.md#maintaining-changelogmd).
- [x] I have added a description with sufficient context for reviewers
to understand this PR.
- [x] I have tested that my changes work as expected and I added a
testing plan to the PR description (if applicable).

---------

Co-authored-by: satushh <satushh@gmail.com>
Co-authored-by: Jun Song <87601811+syjn99@users.noreply.github.com>
syjn99 added a commit to syjn99/prysm that referenced this pull request Jun 11, 2026
**What type of PR is this?**

 Bug fix


**What does this PR do? Why is it needed?**

- support for ssz on get and propose payload envelope and payload
envelope content
- query parameter for gossip validation on payload envelope

relies on OffchainLabs#16421 and
OffchainLabs#16306, needs some small
changes to hook ptc up, if ptc is no issue 16421 is mainly required

Testing
```
participants:
  - el_type: ethrex
    el_image: ethpandaops/ethrex:glamsterdam-devnet-4
    el_extra_params:
      - --http.api=eth,net,web3,admin
    cl_type: prysm
    cl_image: gcr.io/offchainlabs/prysm/beacon-chain:latest
    vc_image: gcr.io/offchainlabs/prysm/validator:latest
    supernode: true
    count: 2
    cl_extra_params:
      - --subscribe-all-subnets
      - --verbosity=debug
    vc_extra_params:
      - --enable-beacon-rest-api
      - --stateless
      - --verbosity=debug

  - el_type: ethrex
    el_image: ethpandaops/ethrex:glamsterdam-devnet-4
    el_extra_params:
      - --http.api=eth,net,web3,admin
    cl_type: prysm
    cl_image: gcr.io/offchainlabs/prysm/beacon-chain:latest
    vc_image: gcr.io/offchainlabs/prysm/validator:latest
    validator_count: 63
    cl_extra_params:
      - --verbosity=debug
    vc_extra_params:
      - --enable-beacon-rest-api
      - --verbosity=debug

network_params:
  fulu_fork_epoch: 0
  gloas_fork_epoch: 2
  seconds_per_slot: 6
  genesis_delay: 40

additional_services:
  - dora

global_log_level: debug

```

**Which issues(s) does this PR fix?**

partially fixes ethereum/beacon-APIs#580 depends
on shane-moore/beacon-APIs#10
implements ethereum/beacon-APIs#613

**Other notes for review**

**Acknowledgements**

- [x] I have read
[CONTRIBUTING.md](https://github.com/prysmaticlabs/prysm/blob/develop/CONTRIBUTING.md).
- [x] I have included a uniquely named [changelog fragment
file](https://github.com/prysmaticlabs/prysm/blob/develop/CONTRIBUTING.md#maintaining-changelogmd).
- [x] I have added a description with sufficient context for reviewers
to understand this PR.
- [x] I have tested that my changes work as expected and I added a
testing plan to the PR description (if applicable).

---------

Co-authored-by: satushh <satushh@gmail.com>
Co-authored-by: Jun Song <87601811+syjn99@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Gloas api's needed in Gloas fork.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants