fix gloas proposal endpoint support - #16818
Merged
Merged
Conversation
james-prysm
changed the title
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
james-prysm
commented
May 21, 2026
| return | ||
| } | ||
|
|
||
| w.Header().Set(api.VersionHeader, version.String(version.Gloas)) |
Contributor
Author
There was a problem hiding this comment.
not sure if we actually need this, commented on the beacon api
| envRoot := bytesutil.ToBytes32(signed.Message.BeaconBlockRoot) | ||
|
|
||
| if level == broadcastValidationConsensusAndEquivocation { | ||
| if s.ForkchoiceFetcher.HighestReceivedBlockSlot() == envSlot && |
Collaborator
There was a problem hiding this comment.
what happens if you submit a payload late?
Contributor
Author
There was a problem hiding this comment.
changed is this more appropriate?
| } | ||
| } | ||
|
|
||
| st, err := s.StateGenService.StateByRoot(ctx, envRoot) |
Collaborator
There was a problem hiding this comment.
This is going to be slow right
Contributor
Author
There was a problem hiding this comment.
you're right, it's probably wrong too, we should have a hard requirement that it's head, is a race condition an issue? if we haven't processed block yet for state?
satushh
reviewed
May 26, 2026
| if jerr != nil { | ||
| return errors.Wrap(jerr, "could not marshal envelope JSON for fallback") | ||
| } | ||
| return c.handler.Post(ctx, endpoint, nil, bytes.NewBuffer(body), nil) |
Member
There was a problem hiding this comment.
The header should have version info (https://github.com/ethereum/beacon-APIs/pull/580/changes#diff-81ee70f2d3ef064583bf30a5dd912e21e004476334fb825d16e72bc2bd411e12R52)
Contributor
Author
There was a problem hiding this comment.
thanks for catching added it here adding header to api call + reverting unneeded fast path on state by …
Contributor
Author
|
made default gossip validation a todo ( would make this pr much bigger breaking it out as a helper function) |
syjn99
reviewed
Jun 8, 2026
syjn99
reviewed
Jun 8, 2026
Co-authored-by: Jun Song <87601811+syjn99@users.noreply.github.com>
syjn99
reviewed
Jun 9, 2026
syjn99
previously approved these changes
Jun 10, 2026
satushh
previously approved these changes
Jun 10, 2026
james-prysm
enabled auto-merge
June 10, 2026 14:54
satushh
approved these changes
Jun 10, 2026
syjn99
added a commit
to syjn99/prysm
that referenced
this pull request
Jun 11, 2026
**What type of PR is this?** Bug fix **What does this PR do? Why is it needed?** - support for ssz on get and propose payload envelope and payload envelope content - query parameter for gossip validation on payload envelope relies on OffchainLabs#16421 and OffchainLabs#16306, needs some small changes to hook ptc up, if ptc is no issue 16421 is mainly required Testing ``` participants: - el_type: ethrex el_image: ethpandaops/ethrex:glamsterdam-devnet-4 el_extra_params: - --http.api=eth,net,web3,admin cl_type: prysm cl_image: gcr.io/offchainlabs/prysm/beacon-chain:latest vc_image: gcr.io/offchainlabs/prysm/validator:latest supernode: true count: 2 cl_extra_params: - --subscribe-all-subnets - --verbosity=debug vc_extra_params: - --enable-beacon-rest-api - --stateless - --verbosity=debug - el_type: ethrex el_image: ethpandaops/ethrex:glamsterdam-devnet-4 el_extra_params: - --http.api=eth,net,web3,admin cl_type: prysm cl_image: gcr.io/offchainlabs/prysm/beacon-chain:latest vc_image: gcr.io/offchainlabs/prysm/validator:latest validator_count: 63 cl_extra_params: - --verbosity=debug vc_extra_params: - --enable-beacon-rest-api - --verbosity=debug network_params: fulu_fork_epoch: 0 gloas_fork_epoch: 2 seconds_per_slot: 6 genesis_delay: 40 additional_services: - dora global_log_level: debug ``` **Which issues(s) does this PR fix?** partially fixes ethereum/beacon-APIs#580 depends on shane-moore/beacon-APIs#10 implements ethereum/beacon-APIs#613 **Other notes for review** **Acknowledgements** - [x] I have read [CONTRIBUTING.md](https://github.com/prysmaticlabs/prysm/blob/develop/CONTRIBUTING.md). - [x] I have included a uniquely named [changelog fragment file](https://github.com/prysmaticlabs/prysm/blob/develop/CONTRIBUTING.md#maintaining-changelogmd). - [x] I have added a description with sufficient context for reviewers to understand this PR. - [x] I have tested that my changes work as expected and I added a testing plan to the PR description (if applicable). --------- Co-authored-by: satushh <satushh@gmail.com> Co-authored-by: Jun Song <87601811+syjn99@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Bug fix
What does this PR do? Why is it needed?
relies on #16421 and #16306, needs some small changes to hook ptc up, if ptc is no issue 16421 is mainly required
Testing
Which issues(s) does this PR fix?
partially fixes ethereum/beacon-APIs#580 depends on shane-moore/beacon-APIs#10
implements ethereum/beacon-APIs#613
Other notes for review
Acknowledgements